1772645 - `./mach lint -l eslint` fails with ERR_PACKAGE_PATH_NOT_EXPORTED

Status: RESOLVED INVALID

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

> ./mach lint -l eslint --outgoing --fix
An error occurred running eslint. Please check the following error messages:


Oops! Something went wrong! :(

ESLint: 8.14.0

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/definition' is not defined by "exports" in C:\Users\sasch\Documents\GitHub\gecko-dev\tools\lint\eslint\eslint-plugin-mozilla\node_modules\eslint-scope\package.json
    at throwExportsNotFound (internal/modules/esm/resolve.js:285:9)
    at packageExportsResolve (internal/modules/esm/resolve.js:508:3)
    at resolveExports (internal/modules/cjs/loader.js:424:36)
    at Function.Module._findPath (internal/modules/cjs/loader.js:464:31)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:802:27)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (C:\Users\sasch\Documents\GitHub\gecko-dev\node_modules\v8-compile-cache\v8-compile-cache.js:159:20)
    at Object.<anonymous> (C:\Users\sasch\Documents\GitHub\gecko-dev\tools\lint\eslint\eslint-plugin-mozilla\node_modules\@babel\eslint-parser\lib\analyze-scope.cjs:19:5)
    at Module._compile (C:\Users\sasch\Documents\GitHub\gecko-dev\node_modules\v8-compile-cache\v8-compile-cache.js:192:30)

Traceback (most recent call last):
  File "c:\users\sasch\documents\github\gecko-dev\python\mozlint\mozlint\roller.py", line 71, in _run_worker
    res = func(paths, config, **lintargs)
  File "c:\users\sasch\documents\github\gecko-dev\python\mozlint\mozlint\types.py", line 57, in __call__
    return self._lint(paths, config, **lintargs)
  File "c:\users\sasch\documents\github\gecko-dev\python\mozlint\mozlint\types.py", line 148, in _lint
    return func(files, config, **lintargs)
  File "C:\Users\sasch\Documents\GitHub\gecko-dev\tools\lint\eslint\__init__.py", line 93, in lint
    fixed += len(results)
TypeError: object of type 'int' has no len()
An error occurred running eslint. Please check the following error messages:

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Lint and Formatting' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Huh, npm i on tools\lint\eslint\eslint-plugin-mozilla\ fixed it somehow.

> npm i
npm WARN old lockfile 
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile

added 6 packages, removed 26 packages, changed 50 packages, and audited 214 packages in 6s

37 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities