1772677 - Website entry in CardDAV address book with additional backslash

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Andreas]

Attachment: Website_CardDAV.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.63 Safari/537.36 Edg/102.0.1245.33

Steps to reproduce:

Store a website entry for a contact in a CardDAV address book (in my case: a Google AB synced with the build-in CardDAV function). Go to another contact and then back to the first one.

Actual results:

The website entry is missing in the contact overview. When opening the edit form, there is an additional backslash in the URL behind the "https" making it a false entry.

Expected results:

The backslash should not be added.

Comment 1

[Magnus Melin [:mkmelin]]

We currently send something like

BEGIN:VCARD
VERSION:3.0
N:Bla;Test;;;
FN:Test Bla
REV:20220606T102416Z
UID:5f1d6be5979c943d
EMAIL:test.blo@invalid
EMAIL:a2@foo
ITEM1.URL:https://www.thunderbird.net
ITEM1.X-ABLABEL:Other
END:VCARD

Shouldn't this be

URL:https://www.thunderbird.net

Type isn't a valid type for URLs it seems. I'm not sure about the "Other" labelling - whether it's really supported, or if it is, if it's useful.

Comment 2

[Geoff Lankow (:darktrojan)]

It's Google adding the backslash, but I think we should be able to handle it. Investigating.

Comment 3

[Geoff Lankow (:darktrojan)]

The specification says colon characters must not be escaped.

Comment 4

[Christian Riechers]

Still broken in TB102.0b8. This needs to work when 102.0 is released.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1772677 - Fix Google's incorrect character escaping in vCard URLs. r=#thunderbird-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8c304fa97b5b
Fix Google's incorrect character escaping in vCard URLs. r=aleca

Comment 8

[Matt]

Will this also fix the odd appearance of \ following : entered in address book notes discussed here https://support.mozilla.org/en-US/questions/1381760 or is that another bug?

Comment 9

[Andreas]

It's not just the notes field but every text field with a colon.

I created Bug 1777920

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9282981 [details]
Bug 1772677 - Fix Google's incorrect character escaping in vCard URLs. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta.

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 103.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/563e33794132

Comment 13

[Geoff Lankow (:darktrojan)]

Comment on attachment 9282981 [details]
Bug 1772677 - Fix Google's incorrect character escaping in vCard URLs. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.): 103 beta 4
Risk to taking this patch (and alternatives if risky): no

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9282981 [details]
Bug 1772677 - Fix Google's incorrect character escaping in vCard URLs. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 102.0.2:
https://hg.mozilla.org/releases/comm-esr102/rev/8e628b8a7afe