1772767 - [matrix] permanent 'Decrypting...' message if key for decryption is missing

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird 102.0a1 20220530 and 103.0a1 120220605 on Windows 8.1

After the credentials for one, different Matrix account got added to each of the two Thunderbird installations above, the tried to decrypt previous chat history and show "Decrypting..." for the 1:1 chat which persists.

There is a string in the application which is supposed to get used in such cases:
message.decryptionError=Could not decrypt the contents of this message. To request encryption keys from your other devices, right click this message.

Comment 1

[Martin Giger [:freaktechnik]]

If the patch for bug 1770459 works as it should, it will fix this.

Comment 2

[Martin Giger [:freaktechnik]]

there could actually be a missing Decrypting... -> Could not decrypt message path way. I'll have to check how exactly that state change happens.

Comment 3

[Martin Giger [:freaktechnik]]

(In reply to Martin Giger [:freaktechnik] from comment #2)

there could actually be a missing Decrypting... -> Could not decrypt message path way. I'll have to check how exactly that state change happens.

Okay, I think the path is exactly as it should be in the patch for bug 1770459 - sadly hard to reliably test.

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: Bug 1772767 - Fix some edge cases where chat message replacement would fail. r=#thunderbird-reviewers

Fixes a race where the message was not yet displayed but already queued for display, and the unread ruler (green line) being removed replacing the message with an older version of itself.

Comment 5

[Martin Giger [:freaktechnik]]

Turns out this was not a bug specific to the Matrix code. At least the leftover cases I found after bug 1770459.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6e20cb4bac84
Fix some edge cases where chat message replacement would fail. r=mkmelin

Comment 7

[Martin Giger [:freaktechnik]]

Comment on attachment 9281441 [details]
Bug 1772767 - Fix some edge cases where chat message replacement would fail. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Some encrypted messages will never show up in their decrypted form or may regress back to their "Decrypting..." form
Testing completed (on c-c, etc.): Manually verified in Nightly.
Risk to taking this patch (and alternatives if risky): Low risk, changes edge case behavior.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9281441 [details]
Bug 1772767 - Fix some edge cases where chat message replacement would fail. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 102.0beta7:
https://hg.mozilla.org/releases/comm-beta/rev/586cf9f0d6b6

Comment 10

[Jason Dunsmore]

I'm seeing this in 102.0. I don't see a way to request encryption keys. And worse, I intuitively double-click on the "Decrypting..." message and that causes the message to be deleted, so I can't see it from other devices either.

Comment 11

[Martin Giger [:freaktechnik]]

(In reply to Jason Dunsmore from comment #10)

I'm seeing this in 102.0. I don't see a way to request encryption keys. And worse, I intuitively double-click on the "Decrypting..." message and that causes the message to be deleted, so I can't see it from other devices either.

If there's no context menu action to request decryption keys this is probably a different bug. I haven't yet had a chance to track down an issue I'm aware of, where the decrypted message is never shown in a conversation that you've previously opened but isn't the currently active conversation.