1772840 - If the toolbox was zoomed other than 100% , the tooltip of the button is incorrectly positioned.

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Alice0775 White]

Attachment: screenshot

Steps to reproduce:

1. Open Browser Toolbox (Ctrl+Shift+Alt+I)
2. Zoom (Ctrl++ or Ctrl+-)
3. Mouse hover over toolbottun

Actual Results:
Tooltip positioned incorrectly

See attached

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6f7359f06455848e6ad8761d191716e43430e8e9&tochange=85fb6ffa2887b21084c20349e999b1ec46db1993

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1753836, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1772840 - Fix zoom handling in nsXULTooltipListener. r=#layout,mstange

If the tooltip node and the target node are in different documents, we'd
use the tooltip's CSS-to-dev-pixel scale to convert.

This is basically bug 1756323 but for XUL, I thought we wouldn't have
cross-document zoom like that but apparently I was wrong...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/56f71bae41a3
Fix zoom handling in nsXULTooltipListener. r=mstange

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/56f71bae41a3

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR102 approval when you get a chance.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9279879 [details]
Bug 1772840 - Fix zoom handling in nsXULTooltipListener. r=#layout,mstange

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Simple fix for tooltips on zoomed devtools.
• User impact if declined: Mispositioned tooltips when devtools are zoomed.
• Fix Landed on Version: 103
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple fix similar to an existing fix for web content that landed a while back.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on Firefox 102.0(build ID: 20220623063721) on Windows 10 64-bits. Verified as fixed on Firefox 103.0b5(build ID: 20220705185846) and Nightly 104.0a1(buildID: 20220706214039) on Windows 10 64-bits, macOS 11 and Ubuntu 22.04.

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9279879 [details]
Bug 1772840 - Fix zoom handling in nsXULTooltipListener. r=#layout,mstange

Approved for 102.1esr.

Comment 12

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/cd6364dc0f86

Comment 13

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello,
I confirm this fix is verified on Firefox 102.1.0esr(build ID: 20220707163442) on macOS 11, Windows 10 64-bits and Ubuntu 22.04