Closed Bug 1772943 Opened 3 years ago Closed 3 years ago

Remove osfile.jsm usage from toolkit/mozapps/

Categories

(Toolkit Graveyard :: OS.File, task, P3)

Product:
Toolkit Graveyard
Component:
OS.File
Type:
task

Tracking

(firefox105 fixed)

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: beth, Assigned: beth)

References

Details

Attachments

(1 file)

Bug 1772943 - Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r?gijs
48 bytes, text/x-phabricator-request
Details | Review
Assignee: nobody → brennie
Depends on: 1773186
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e64335287775 Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy

Backed out for causing mochitest failures on browser_disco_taar_telemetry.js. CLOSED TREE
Backout link
Push with failures
Link to failure log 1
Link to failure log 2
Failure line :
TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_disco_taar_telemetry.js | Uncaught exception in setup - OperationError: Could not parse path (browser/toolkit/mozapps/extensions/test/browser/discovery/api_response.json): NS_ERROR_FILE_UNRECOGNIZED_PATH
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js | xpcshell return code: 0
[task 2022-07-10T03:10:48.154Z] 03:10:48 INFO - TEST-INFO took 491ms

Flags: needinfo?(brennie)
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3ba86211812 Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy

Backed out for causing mochitest failures on browser_html_discover_view.js

Failure line: TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Uncaught exception in test - OperationError: Could not parse path (browser/toolkit/mozapps/extensions/test/browser/discovery/api_response.json): NS_ERROR_FILE_UNRECOGNIZED_PATH

Push with failures

Failure log

Backout link

[task 2022-07-12T10:33:22.170Z] 10:33:22     INFO - TEST-START | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js
[task 2022-07-12T10:33:22.292Z] 10:33:22     INFO - TEST-INFO | started process screentopng
[task 2022-07-12T10:33:22.835Z] 10:33:22     INFO - TEST-INFO | screentopng: exit 0
[task 2022-07-12T10:33:22.836Z] 10:33:22     INFO - Buffered messages logged at 10:33:22
[task 2022-07-12T10:33:22.837Z] 10:33:22     INFO - Entering setup bound 
[task 2022-07-12T10:33:22.837Z] 10:33:22     INFO - Leaving setup bound 
[task 2022-07-12T10:33:22.838Z] 10:33:22     INFO - Entering test bound discopane_with_real_api_data
[task 2022-07-12T10:33:22.838Z] 10:33:22     INFO - Buffered messages finished
[task 2022-07-12T10:33:22.839Z] 10:33:22     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Uncaught exception in test - OperationError: Could not parse path (browser/toolkit/mozapps/extensions/test/browser/discovery/api_response.json): NS_ERROR_FILE_UNRECOGNIZED_PATH
[task 2022-07-12T10:33:22.839Z] 10:33:22     INFO - Stack trace:
[task 2022-07-12T10:33:22.840Z] 10:33:22     INFO - readAPIResponseFixture@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head_disco.js:50:31
[task 2022-07-12T10:33:22.840Z] 10:33:22     INFO - discopane_with_real_api_data@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js:222:25
[task 2022-07-12T10:33:22.841Z] 10:33:22     INFO - handleTask@chrome://mochikit/content/browser-test.js:988:26
[task 2022-07-12T10:33:22.841Z] 10:33:22     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1060:18
[task 2022-07-12T10:33:22.842Z] 10:33:22     INFO - Leaving test bound discopane_with_real_api_data
[task 2022-07-12T10:33:22.842Z] 10:33:22     INFO - Entering test bound install_from_discopane
[task 2022-07-12T10:33:22.842Z] 10:33:22     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-07-12T10:33:22.847Z] 10:33:22     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Uncaught exception in test - OperationError: Could not parse path (browser/toolkit/mozapps/extensions/test/browser/discovery/api_response.json): NS_ERROR_FILE_UNRECOGNIZED_PATH
[task 2022-07-12T10:33:22.847Z] 10:33:22     INFO - Stack trace:
[task 2022-07-12T10:33:22.848Z] 10:33:22     INFO - readAPIResponseFixture@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head_disco.js:50:31
[task 2022-07-12T10:33:22.848Z] 10:33:22     INFO - install_from_discopane@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js:335:25
[task 2022-07-12T10:33:22.848Z] 10:33:22     INFO - handleTask@chrome://mochikit/content/browser-test.js:988:26
[task 2022-07-12T10:33:22.848Z] 10:33:22     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1060:18
[task 2022-07-12T10:33:22.848Z] 10:33:22     INFO - Leaving test bound install_from_discopane
[task 2022-07-12T10:33:22.848Z] 10:33:22     INFO - Entering test bound discopane_navigate_while_loading
[task 2022-07-12T10:33:22.849Z] 10:33:22     INFO - Loading manager window in tab
[task 2022-07-12T10:33:22.849Z] 10:33:22     INFO - GECKO(1619) | [Child 1738: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f0a75a86000 == 2 [pid = 1738] [id = 99]
[task 2022-07-12T10:33:22.849Z] 10:33:22     INFO - GECKO(1619) | [Child 1738: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7f0a90a91d90) [pid = 1738] [serial = 202] [outer = 0]
[task 2022-07-12T10:33:22.850Z] 10:33:22     INFO - GECKO(1619) | [Child 1738: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (7f0a75a86800) [pid = 1738] [serial = 203] [outer = 7f0a90a91d90]
[task 2022-07-12T10:33:22.850Z] 10:33:22     INFO - GECKO(1619) | [Child 1776, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:498
[task 2022-07-12T10:33:22.850Z] 10:33:22     INFO - GECKO(1619) | [Child 1738, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:498
[task 2022-07-12T10:33:22.850Z] 10:33:22     INFO - GECKO(1619) | [Parent 1619: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fdbfbeefc00 == 17 [pid = 1619] [id = 178]
[task 2022-07-12T10:33:22.850Z] 10:33:22     INFO - GECKO(1619) | [Parent 1619: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 133 (7fdc15e70130) [pid = 1619] [serial = 501] [outer = 0]
[task 2022-07-12T10:33:22.850Z] 10:33:22     INFO - GECKO(1619) | [Parent 1619: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 134 (7fdc0bd95000) [pid = 1619] [serial = 502] [outer = 7fdc15e70130]
[task 2022-07-12T10:33:22.850Z] 10:33:22     INFO - GECKO(1619) | [Parent 1619: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 135 (7fdc16a66400) [pid = 1619] [serial = 503] [outer = 7fdc15e70130]
[task 2022-07-12T10:33:22.850Z] 10:33:22     INFO - GECKO(1619) | [Parent 1619, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1234
[task 2022-07-12T10:33:22.851Z] 10:33:22     INFO - GECKO(1619) | [Parent 1619, Main Thread] WARNING: 'aOwner->IsDiscarded()', file /builds/worker/workspace/obj-build/dist/include/mozilla/dom/SyncedContextInlines.h:95
[task 2022-07-12T10:33:22.856Z] 10:33:22     INFO - GECKO(1619) | [Parent 1619, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp:4063
[task 2022-07-12T10:33:22.949Z] 10:33:22     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Should have an add-ons manager window - 
[task 2022-07-12T10:33:22.951Z] 10:33:22     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Should be displaying the correct UI - 
[task 2022-07-12T10:33:22.987Z] 10:33:22     INFO - window has focus, waiting for manager load
[task 2022-07-12T10:33:22.988Z] 10:33:22     INFO - Waiting for initialization
[task 2022-07-12T10:33:22.990Z] 10:33:22     INFO - Manager waiting for view load
[task 2022-07-12T10:33:22.992Z] 10:33:22     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Discovery cards should have started to initialize - 
[task 2022-07-12T10:33:23.050Z] 10:33:23     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Should be at the extension list view - 
[task 2022-07-12T10:33:23.052Z] 10:33:23     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | discopane should still not be updated because the request is blocked - 
[task 2022-07-12T10:33:23.054Z] 10:33:23     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Discopane should be removed after switching to the extension list - 
[task 2022-07-12T10:33:23.105Z] 10:33:23     INFO - GECKO(1619) | [Parent 1619, Main Thread] WARNING: 'NS_FAILED(rr->RetargetDeliveryTo(sts))', file /builds/worker/checkouts/gecko/dom/fetch/FetchDriver.cpp:1213
[task 2022-07-12T10:33:23.109Z] 10:33:23     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Should still be at the extension list view - 
[task 2022-07-12T10:33:23.112Z] 10:33:23     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Discopane should not be in the document when it is not the active view - 
[task 2022-07-12T10:33:23.113Z] 10:33:23     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Discovery API should be fetched once - 
[task 2022-07-12T10:33:23.115Z] 10:33:23     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Should have an add-ons manager window to close - 
[task 2022-07-12T10:33:23.116Z] 10:33:23     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Should be closing window with correct URI - 
[task 2022-07-12T10:33:23.117Z] 10:33:23     INFO - Telling manager window to close
Flags: needinfo?(brennie)

Hi Barret,

This also started to appear again. Can you please take another look ?
Failure log : https://treeherder.mozilla.org/logviewer?job_id=384080987&repo=autoland&lineNumber=3899
Failure line :
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_upgrade_incompatible.js | xpcshell return code: 0

Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6db198ff02c Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy

Backed out for causing mochitest failures on browser_doorhanger_installs.js

Backout link

Push with failures

Failure log

Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2452afd0a516 Port osfile.jsm usage to IOUtils in toolkit/mozapps/ r=Gijs,mixedpuppy
Flags: needinfo?(brennie)

https://hg.mozilla.org/mozilla-central/rev/2452afd0a516

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Blocks: 1801445
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: