1773186 - Add file hashing to IOUtils with Digest

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, enhancement, P3)

Description

[Beth Rennie [:beth] (she/her)]

ProductAddonChecker.jsm does a streaming file hash with OS.File and nsICryptoHash. (note: only the file IO is async, the hash computation is done on main thread).

There is no easy way to do this with IOUtils presently as we return all the file data at once. However, it would be easy to add a method on IOUtils to do the streaming hashing on the background thread with nsICryptoHash::UpdateFromStream

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1773186 - Add IOUtils::ComputeHexDigest r?nika

Depends on D148965

Comment 2

[Beth Rennie [:beth] (she/her)]

We don't want to use nsICryptoHash for new code but want to use Digest instead

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ec51be873d4
Add IOUtils::ComputeHexDigest r=nika,keeler

Comment 4

[Sandor Molnar[:smolnar]]

Backed out 2 changesets (bug 1773186, bug 1772742) for causing mochitest failures in dom/system/tests/ioutils/test_ioutils_hashfile.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/dd7b5b6df782dc47bd55a5516433424e05e9d147

Push with failures

Failure log

INFO - TEST-UNEXPECTED-FAIL | dom/system/tests/ioutils/test_ioutils_hashfile.html | TypeError: IOUtils.hashFile is not a function - Should not throw any errors

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b10faac4d933
Add IOUtils::ComputeHexDigest r=nika,keeler

Comment 6

[Marian-Vasile Laza]

Backed out changeset b10faac4d933 (Bug 1773186) for causing bustages on chrome.ini (test_ioutils_hashfile.html).
Backout link
Push with failures
Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7d7af6a5401
Add IOUtils::ComputeHexDigest r=nika,keeler

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f7d7af6a5401