1772945 - Enable "css-masonry" on Thunderbird release builds

Status: RESOLVED FIXED

(Toolkit :: FeatureGate, task, P3)

Description

[Rob Lemley [:rjl]]

The new Thunderbird Address Book UI makes use of grid-template-rows: masonry layout, which needs to be enabled for Thunderbird 102.

That feature is enabled by a preferences and is enabled or not by "css-masonry" feature gate. Currently, the feature is only enabled by default on "Nightly" releases. The pref itself can be set in all-thunderbird.js, but causes a XPCShell test failure Bug 1771811 comment 6.

This bug is to add the ability to target Thunderbird with a gated feature and then enable css-masonry by default.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1772945 - Allow targeting gated features to Thunderbird. r=gijs

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1772945 - Enable "css-masonry" feature for Thunderbird. r=gijs

The new address book layout in Thunderbird 102 uses masonry layout.
The UI team has requested that the feature be turned on as another
approach would not work as well due to the dynamic and modular
nature of the new UI.

Depends on D148450

Comment 3

[:Gijs (back Mon 10; he/him)]

Should this be assigned to you, Rob? And any suggestions for priority/severity?

Comment 4

[Rob Lemley [:rjl]]

It's technically just fixing a test failure for Thunderbird, so not super high priority. It's ready for review, just haven't identified who can/should review.

Comment 5

[:Gijs (back Mon 10; he/him)]

(In reply to Rob Lemley [:rjl] from comment #4)

It's technically just fixing a test failure for Thunderbird, so not super high priority. It's ready for review, just haven't identified who can/should review.

I can review this - if you add me as a reviewer and publish the revisions I should be able to get to it today.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/436519a97070
Allow targeting gated features to Thunderbird. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/db816d9b07ce
Enable "css-masonry" feature for Thunderbird. r=Gijs,preferences-reviewers

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/436519a97070
https://hg.mozilla.org/mozilla-central/rev/db816d9b07ce

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9279953 [details]
Bug 1772945 - Allow targeting gated features to Thunderbird. r=gijs

Beta/Release Uplift Approval Request

• User impact if declined: No user impact for Firefox.
  No user impact for Thunderbird.
  The second patch fixes a perma-fail on Thunderbird release/beta builds by setting the default (true) that the feature gate expects to what's actually set in all-thunderbird.js. One (6?) less failure to look at. Bug 1771811.

Verifying in Nightly is not possible because the feature is already enabled. I did run a try build with the update channel set to beta and did not see the test fail.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This adds the ability to use gated features that target Thunderbird specifically via AppConstants.MOZ_APP_NAME. This is in line with existing gated feature tests that used AppConstants.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9279953 [details]
Bug 1772945 - Allow targeting gated features to Thunderbird. r=gijs

Approved for landing on the beta branch before Monday merge, it will be in the release candidate.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/cdba89d20c8c
https://hg.mozilla.org/releases/mozilla-beta/rev/93a486e3717b

Comment 11

[Intermittent Failures Robot]

8 failures in 3170 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-beta: 8

Platform and build breakdown:

• linux1804-64-shippable-qr: 2
  • opt: 2
• windows10-32-2004-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1772945&startday=2022-06-13&endday=2022-06-19&tree=all