1771811 - [102 only] grid-template-rows: masonry; comm/mail/test/static/browser_parsable_css.js | Got error message for chrome://messenger/skin/aboutAddressBook.css: Error in parsing value for ‘grid-template-rows’. Declaration dropped. -

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: thunderbird [at] calypsoblue.org
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=379673029&repo=comm-beta
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/I4ElNSS4RgSpzisZ3M2C0g/runs/0/artifacts/public/logs/live_backing.log

---

`grid-template-rows` does not support `masonry` except on Nightly. Also seen in `vcard-edit.css`.

Comment 1

[Rob Lemley [:rjl]]

This is blocking 102.0b1.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1771811 - Enable "masonry" grid layout. r=#thunderbird-reviewers

The new Addressbook UI uses masonry layout in the grid. It needs to
be activated by pref in order to be available.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/32d16ea55d46
Enable "masonry" grid layout. r=aleca

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9278855 [details]
Bug 1771811 - Enable "masonry" grid layout. r=#thunderbird-reviewers

[Triage Comment]
Approved for 102.0beta1

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 102.0beta1:
https://hg.mozilla.org/releases/comm-beta/rev/077fd0a76167

Comment 6

[Rob Lemley [:rjl]]

Manipulating the featuregate preference directly like this causes a perma-fail with the featuregate tests.

https://treeherder.mozilla.org/logviewer?job_id=379773623&repo=comm-beta&lineNumber=4464

WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 439] Feature layout.css.grid-template-masonry-value.enabled should match runtime value. - false == true

We can try to target the feature so that it's always enabled for Thunderbird. A targetting fact needs to be added here and then the feature config updated here.

For the targeting fact: ["thunderbird", AppConstants.MOZ_APP_NAME === "thunderbird"] should work, then default-value for css-masonry would become {default = false, nightly = true, thunderbird = true}.

We'd have to move on this pretty quickly to get the change in while 102 is in beta. Are there any alternatives?

Comment 7

[Alessandro Castellani [:aleca]]

If possible we should definitely pursue this.
I'm not sure I'm missing something but I don't see any potential issue in enabling a masonry layout for our content.
Especially the new address book UI, which is modular and extremely prone to drastic data alteration (not every contact will have/need the same layout), will benefit greatly from this and another UI approach wouldn't work as well.

Comment 8

[Rob Lemley [:rjl]]

Jared -- I'm not sure if you're the right person to ask for input. Given that we want css-masonry enabled for Thunderbird 102, is the approach described in comment 6 going to work out?

Comment 9

[Intermittent Failures Robot]

5 failures in 2917 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-beta: 5

Platform and build breakdown:

• linux1804-64-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 1
  • opt: 1
• windows10-32-2004-shippable-qr: 1
  • opt: 1
• windows10-64-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1771811&startday=2022-05-30&endday=2022-06-05&tree=all

Comment 10

[Rob Lemley [:rjl]]

If bug 1772945 changes are accepted and uplifted, this will go away.

Comment 11

[Magnus Melin [:mkmelin]]

bug 1772945 landed