1773076 - Allow theme_experiments for permanently installed addons not signed as privileged on builds that allows disabling signatures

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The part of Bug 1739114 changes that has been landed in Nightly 103 is currently preventing theme_experiments to be used in themes installed as non-temporary and not signed as privileged (e.g. see Bug 1739114 comment 29), and that is actually a change in behavior from what the MDN docs states:

Note: This key is only available for use in Firefox Developer Edition and Firefox Nightly channels and requires the extensions.experiments.enabled preference to be enabled. In Firefox 73 and earlier, the extensions.legacy.enabled had to be used instead.

(quoted from https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme_experiment)

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1773076 - theme_experiment should be allowed to addons installed non-temporarily on builds allowing disabled signature checks. r?willdurand!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ec447f44180
theme_experiment should be allowed to addons installed non-temporarily on builds allowing disabled signature checks. r=willdurand

Comment 3

[Sandor Molnar[:smolnar]]

Backed out changeset 3ec447f44180 (bug 1773076) for causing xpc failure in test_ext_theme_experiments and lint failure.

Backout link: https://hg.mozilla.org/integration/autoland/rev/da23d8aba2aac7f81569c009bbab3c7300cda89e

Push with failures

Failure log xpc

Failure log browser-chrome

Failure log lint

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Turned out that all those 3 failures are all related to the patch attached to this bug being landed along with ESMfication changes to Extension.jsm introduced by Bug 1772101:

• the lint, xpc and browser-chrome failures are all because AddonSettings should now be lazy.AddonSettings:
  • xpc: https://treeherder.mozilla.org/logviewer?job_id=380788370&repo=autoland&lineNumber=3798-3815
  • browser-chrome: https://treeherder.mozilla.org/logviewer?job_id=380788079&repo=autoland&lineNumber=18142-18149
  • lint: https://treeherder.mozilla.org/logviewer?job_id=380787110&repo=autoland&lineNumber=108

I've updated the patch accordingly and pushed to try to confirm that there aren't other failures hidden behind this one:

• linux64 mochitest, xpcshell and test-verify: https://treeherder.mozilla.org/jobs?repo=try&revision=2ac732a5235499497638e355b31ceafcc72bceea
• android xpcshell and test-verify: https://treeherder.mozilla.org/jobs?repo=try&revision=ac425ee5fcc792b4ab3ca141a022eb4a84a9b94a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edbcbb3caf64
theme_experiment should be allowed to addons installed non-temporarily on builds allowing disabled signature checks. r=willdurand

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug 1773076 - Port to TB: theme_experiment should be allowed to addons installed non-temporarily on builds allowing disabled signature checks. r=mkmelin

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/edbcbb3caf64

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e281a543eaa5
Port to TB: theme_experiment should be allowed to addons installed non-temporarily on builds allowing disabled signature checks. r=mkmelin

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1773076 - Make test_ext_theme_experiments.js | test_unprivileged_theme work when experiments are enabled by default. r=rpl

Test failing for Thunderbird atm.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c166f218018
Make test_ext_theme_experiments.js | test_unprivileged_theme work when experiments are enabled by default. r=rpl

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9c166f218018

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1739114