1773212 - Privacy pane scrolls horizontally in narrow windows due to unwrappable checkbox for OS auth for creditcard autofill

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[berti]

Attachment: Bildschirmfoto 2022-06-08 um 09.13.58.pdf

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

I try it with a new Profile, but still the same

Actual results:

see screenshot

Expected results:

in about:preferences#general and the other pref-pages the resizing is working

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Preferences' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

Paul, is there bandwidth on your team to improve the situation here? Feels like a lot of the width is coming from the big tracking protection section at the top, and that is even worse in German because the dropdown language under "strict" is so much longer as well.

Comment 3

[Paul Zühlcke [:pbz]]

I don't think it's the ETP section that is adding a lot of width. When I remove that via devtools the page still doesn't shrink much further. Could it be related to the sections which checkbox and button in one row?
I'm wondering if this is a regression, running a mozregression might be helpful.

Comment 4

[:Gijs (he/him)]

Did this use to work better in earlier versions of Firefox, and if so would you be comfortable running mozregression to find out when exactly we broke something here?

Comment 6

[berti]

I don't know exactly when the problem came up.
I think it must be around Version 96-98
sorry but I really don't know what to do with mozregression, I'm only an Enduser

Comment 7

[Yves Goergen]

mozregression said this:

(...)
2022-06-26T13:19:43.647000: INFO : b'[fluent] Missing message in locale de: update-application-suppress-prompts'
2022-06-26T13:19:43.650000: INFO : b'[fluent] Missing message in locale de: update-application-suppress-prompts'
2022-06-26T13:19:44.205000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-16-16-17-16-mozilla-central/ HTTP/1.1" 200 47157
2022-06-26T13:19:44.240000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-16-21-40-05-mozilla-central/ HTTP/1.1" 200 None
2022-06-26T13:19:44.754000: DEBUG : got valid_builds [(1, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-16-16-17-16-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-16-16-17-16-mozilla-central/firefox-99.0a1.en-US.win64.txt'}), (0, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-16-21-40-05-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-16-21-40-05-mozilla-central/firefox-99.0a1.en-US.win64.txt'})]
2022-06-26T13:19:44.754000: DEBUG : Update build info from {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-16-21-40-05-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-16-21-40-05-mozilla-central/firefox-99.0a1.en-US.win64.txt'}
2022-06-26T13:19:44.754000: DEBUG : Fetching txt info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-16-21-40-05-mozilla-central/firefox-99.0a1.en-US.win64.txt
2022-06-26T13:19:44.755000: DEBUG : redo: attempt 1/3
2022-06-26T13:19:44.755000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-16-21-40-05-mozilla-central/firefox-99.0a1.en-US.win64.txt',), kwargs: {}, attempt #1
2022-06-26T13:19:45.197000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-16-21-40-05-mozilla-central/firefox-99.0a1.en-US.win64.txt HTTP/1.1" 200 99
2022-06-26T13:19:45.200000: DEBUG : Get URLs for 2022-02-10
2022-06-26T13:19:45.201000: DEBUG : got build_urls ['https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central-l10n/', 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-06-57-47-mozilla-central-l10n/']
2022-06-26T13:19:45.202000: DEBUG : Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central-l10n/
2022-06-26T13:19:45.202000: DEBUG : redo: attempt 1/3
2022-06-26T13:19:45.202000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central-l10n/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:19:45.203000: DEBUG : Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-06-57-47-mozilla-central-l10n/
2022-06-26T13:19:45.205000: DEBUG : redo: attempt 1/3
2022-06-26T13:19:45.205000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-06-57-47-mozilla-central-l10n/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:19:45.732000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-16-21-40-05-mozilla-central-l10n/firefox-99.0a1.de.win64.zip HTTP/1.1" 200 84901861
2022-06-26T13:19:49.414000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central-l10n/ HTTP/1.1" 200 None
2022-06-26T13:19:49.898000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-10-06-57-47-mozilla-central-l10n/ HTTP/1.1" 200 None
2022-06-26T13:19:51.323000: DEBUG : redo: attempt 1/3
2022-06-26T13:19:51.324000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:19:51.908000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central/ HTTP/1.1" 200 47157
2022-06-26T13:19:52.539000: DEBUG : redo: attempt 1/3
2022-06-26T13:19:52.539000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-06-57-47-mozilla-central/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:19:53.196000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-10-06-57-47-mozilla-central/ HTTP/1.1" 200 47157
2022-06-26T13:19:53.565000: DEBUG : got valid_builds [(0, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central/firefox-99.0a1.en-US.win64.txt'}), (1, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-06-57-47-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-06-57-47-mozilla-central/firefox-99.0a1.en-US.win64.txt'})]
2022-06-26T13:19:53.565000: DEBUG : Update build info from {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central/firefox-99.0a1.en-US.win64.txt'}
2022-06-26T13:19:53.565000: DEBUG : Fetching txt info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central/firefox-99.0a1.en-US.win64.txt
2022-06-26T13:19:53.566000: DEBUG : redo: attempt 1/3
2022-06-26T13:19:53.566000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central/firefox-99.0a1.en-US.win64.txt',), kwargs: {}, attempt #1
2022-06-26T13:19:54.055000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central/firefox-99.0a1.en-US.win64.txt HTTP/1.1" 200 99
2022-06-26T13:19:54.604000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-10-21-31-01-mozilla-central-l10n/firefox-99.0a1.de.win64.zip HTTP/1.1" 200 84772250
2022-06-26T13:19:55.155000: INFO : Narrowed nightly regression window from [2022-02-07, 2022-02-18] (11 days) to [2022-02-07, 2022-02-13] (6 days) (~2 steps left)
2022-06-26T13:20:05.537000: INFO : Running mozilla-central-l10n build for 2022-02-10
2022-06-26T13:20:05.539000: DEBUG : Get URLs for 2022-02-12
2022-06-26T13:20:05.539000: DEBUG : got build_urls ['https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central-l10n/', 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-11-53-33-mozilla-central-l10n/', 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-09-47-43-mozilla-central-l10n/']
2022-06-26T13:20:05.540000: DEBUG : Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central-l10n/
2022-06-26T13:20:05.541000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:05.541000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central-l10n/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:05.541000: DEBUG : Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-11-53-33-mozilla-central-l10n/
2022-06-26T13:20:05.542000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:05.542000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-11-53-33-mozilla-central-l10n/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:05.545000: DEBUG : urllib3.connectionpool: Resetting dropped connection: archive.mozilla.org
2022-06-26T13:20:07.009000: INFO : Launching C:\Users\Yves\AppData\Local\Temp\tmpuynqomyz\firefox\firefox.exe
2022-06-26T13:20:07.011000: INFO : Application command: C:\Users\Yves\AppData\Local\Temp\tmpuynqomyz\firefox\firefox.exe --wait-for-browser -profile C:\Users\Yves\AppData\Local\Temp\tmpnpr3s7yj.mozrunner
2022-06-26T13:20:07.054000: INFO : application_buildid: 20220210213101
2022-06-26T13:20:07.054000: INFO : application_changeset: e8444fbb022b362e2721a5ad6461a32037017df1
2022-06-26T13:20:07.055000: INFO : application_display_name: Firefox Nightly
2022-06-26T13:20:07.055000: INFO : application_id: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
2022-06-26T13:20:07.055000: INFO : application_name: Firefox
2022-06-26T13:20:07.055000: INFO : application_remotingname: firefox-nightly
2022-06-26T13:20:07.055000: INFO : application_repository: https://hg.mozilla.org/mozilla-central
2022-06-26T13:20:07.055000: INFO : application_vendor: Mozilla
2022-06-26T13:20:07.055000: INFO : application_version: 99.0a1
2022-06-26T13:20:07.055000: INFO : platform_buildid: 20220210213101
2022-06-26T13:20:07.056000: INFO : platform_changeset: e8444fbb022b362e2721a5ad6461a32037017df1
2022-06-26T13:20:07.056000: INFO : platform_repository: https://hg.mozilla.org/mozilla-central
2022-06-26T13:20:07.056000: INFO : platform_version: 99.0a1
2022-06-26T13:20:10.102000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-12-11-53-33-mozilla-central-l10n/ HTTP/1.1" 200 None
2022-06-26T13:20:10.751000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central-l10n/ HTTP/1.1" 200 None
2022-06-26T13:20:13.406000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:13.592000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-11-53-33-mozilla-central/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:13.770000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:13.770000: INFO : b'[fluent] Missing message in locale de: update-application-suppress-prompts'
2022-06-26T13:20:13.770000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:14.282000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-12-11-53-33-mozilla-central/ HTTP/1.1" 200 None
2022-06-26T13:20:14.323000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central/ HTTP/1.1" 200 47157
2022-06-26T13:20:14.818000: DEBUG : got valid_builds [(1, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-11-53-33-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-11-53-33-mozilla-central/firefox-99.0a1.en-US.win64.txt'}), (0, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central/firefox-99.0a1.en-US.win64.txt'})]
2022-06-26T13:20:14.819000: DEBUG : Update build info from {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central/firefox-99.0a1.en-US.win64.txt'}
2022-06-26T13:20:14.819000: DEBUG : Fetching txt info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central/firefox-99.0a1.en-US.win64.txt
2022-06-26T13:20:14.819000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:14.819000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central/firefox-99.0a1.en-US.win64.txt',), kwargs: {}, attempt #1
2022-06-26T13:20:15.274000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central/firefox-99.0a1.en-US.win64.txt HTTP/1.1" 200 99
2022-06-26T13:20:15.278000: DEBUG : Get URLs for 2022-02-09
2022-06-26T13:20:15.279000: DEBUG : got build_urls ['https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central-l10n/', 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-09-56-40-mozilla-central-l10n/']
2022-06-26T13:20:15.279000: DEBUG : Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central-l10n/
2022-06-26T13:20:15.280000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:15.280000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central-l10n/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:15.280000: DEBUG : Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-09-56-40-mozilla-central-l10n/
2022-06-26T13:20:15.281000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:15.281000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-09-56-40-mozilla-central-l10n/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:15.818000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-12-21-25-59-mozilla-central-l10n/firefox-99.0a1.de.win64.zip HTTP/1.1" 200 84921366
2022-06-26T13:20:19.652000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central-l10n/ HTTP/1.1" 200 None
2022-06-26T13:20:20.273000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-09-09-56-40-mozilla-central-l10n/ HTTP/1.1" 200 None
2022-06-26T13:20:22.196000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:22.196000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-09-56-40-mozilla-central/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:22.899000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-09-09-56-40-mozilla-central/ HTTP/1.1" 200 47157
2022-06-26T13:20:23.635000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:23.635000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:24.264000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central/ HTTP/1.1" 200 47157
2022-06-26T13:20:24.656000: DEBUG : got valid_builds [(1, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-09-56-40-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-09-56-40-mozilla-central/firefox-99.0a1.en-US.win64.txt'}), (0, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central/firefox-99.0a1.en-US.win64.txt'})]
2022-06-26T13:20:24.656000: DEBUG : Update build info from {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central/firefox-99.0a1.en-US.win64.txt'}
2022-06-26T13:20:24.656000: DEBUG : Fetching txt info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central/firefox-99.0a1.en-US.win64.txt
2022-06-26T13:20:24.656000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:24.656000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central/firefox-99.0a1.en-US.win64.txt',), kwargs: {}, attempt #1
2022-06-26T13:20:25.138000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central/firefox-99.0a1.en-US.win64.txt HTTP/1.1" 200 99
2022-06-26T13:20:25.736000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-09-19-07-11-mozilla-central-l10n/firefox-99.0a1.de.win64.zip HTTP/1.1" 200 84712172
2022-06-26T13:20:26.525000: INFO : Narrowed nightly regression window from [2022-02-07, 2022-02-13] (6 days) to [2022-02-07, 2022-02-10] (3 days) (~1 steps left)
2022-06-26T13:20:36.849000: INFO : Running mozilla-central-l10n build for 2022-02-09
2022-06-26T13:20:36.850000: DEBUG : Get URLs for 2022-02-08
2022-06-26T13:20:36.851000: DEBUG : got build_urls ['https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central-l10n/', 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-07-00-47-mozilla-central-l10n/']
2022-06-26T13:20:36.851000: DEBUG : Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central-l10n/
2022-06-26T13:20:36.852000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:36.852000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central-l10n/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:36.852000: DEBUG : Fetching build info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-07-00-47-mozilla-central-l10n/
2022-06-26T13:20:36.852000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:36.852000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-07-00-47-mozilla-central-l10n/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:36.858000: DEBUG : urllib3.connectionpool: Resetting dropped connection: archive.mozilla.org
2022-06-26T13:20:38.337000: INFO : Launching C:\Users\Yves\AppData\Local\Temp\tmp2hqy3nx5\firefox\firefox.exe
2022-06-26T13:20:38.338000: INFO : Application command: C:\Users\Yves\AppData\Local\Temp\tmp2hqy3nx5\firefox\firefox.exe --wait-for-browser -profile C:\Users\Yves\AppData\Local\Temp\tmpv4x2y5qp.mozrunner
2022-06-26T13:20:38.381000: INFO : application_buildid: 20220209190711
2022-06-26T13:20:38.381000: INFO : application_changeset: 76e48e33855f2bacad3301ebe987e46ff65db5cf
2022-06-26T13:20:38.381000: INFO : application_display_name: Firefox Nightly
2022-06-26T13:20:38.381000: INFO : application_id: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
2022-06-26T13:20:38.382000: INFO : application_name: Firefox
2022-06-26T13:20:38.382000: INFO : application_remotingname: firefox-nightly
2022-06-26T13:20:38.382000: INFO : application_repository: https://hg.mozilla.org/mozilla-central
2022-06-26T13:20:38.382000: INFO : application_vendor: Mozilla
2022-06-26T13:20:38.382000: INFO : application_version: 99.0a1
2022-06-26T13:20:38.382000: INFO : platform_buildid: 20220209190711
2022-06-26T13:20:38.382000: INFO : platform_changeset: 76e48e33855f2bacad3301ebe987e46ff65db5cf
2022-06-26T13:20:38.382000: INFO : platform_repository: https://hg.mozilla.org/mozilla-central
2022-06-26T13:20:38.382000: INFO : platform_version: 99.0a1
2022-06-26T13:20:41.369000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-08-07-00-47-mozilla-central-l10n/ HTTP/1.1" 200 None
2022-06-26T13:20:41.879000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central-l10n/ HTTP/1.1" 200 None
2022-06-26T13:20:43.703000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:43.703000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-07-00-47-mozilla-central/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:44.457000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-08-07-00-47-mozilla-central/ HTTP/1.1" 200 47157
2022-06-26T13:20:44.980000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:44.980000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central/',), kwargs: {'auth': None}, attempt #1
2022-06-26T13:20:44.983000: INFO : b'[fluent] Missing message in locale de: update-application-suppress-prompts'
2022-06-26T13:20:44.983000: INFO : b'[fluent] Missing message in locale de: update-application-suppress-prompts'
2022-06-26T13:20:45.506000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central/ HTTP/1.1" 200 None
2022-06-26T13:20:45.879000: DEBUG : got valid_builds [(1, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-07-00-47-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-07-00-47-mozilla-central/firefox-99.0a1.en-US.win64.txt'}), (0, {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central/firefox-99.0a1.en-US.win64.txt'})]
2022-06-26T13:20:45.879000: DEBUG : Update build info from {'build_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central-l10n/firefox-99.0a1.de.win64.zip', 'build_txt_url': 'https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central/firefox-99.0a1.en-US.win64.txt'}
2022-06-26T13:20:45.879000: DEBUG : Fetching txt info from https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central/firefox-99.0a1.en-US.win64.txt
2022-06-26T13:20:45.879000: DEBUG : redo: attempt 1/3
2022-06-26T13:20:45.879000: DEBUG : redo: retry: calling _default_get with args: ('https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central/firefox-99.0a1.en-US.win64.txt',), kwargs: {}, attempt #1
2022-06-26T13:20:46.322000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central/firefox-99.0a1.en-US.win64.txt HTTP/1.1" 200 99
2022-06-26T13:20:46.810000: DEBUG : urllib3.connectionpool: https://archive.mozilla.org:443 "GET /pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central-l10n/firefox-99.0a1.de.win64.zip HTTP/1.1" 200 84773366
2022-06-26T13:20:47.909000: INFO : Narrowed nightly regression window from [2022-02-07, 2022-02-10] (3 days) to [2022-02-07, 2022-02-09] (2 days) (~1 steps left)
2022-06-26T13:20:57.684000: INFO : Running mozilla-central-l10n build for 2022-02-08
2022-06-26T13:20:59.129000: INFO : Launching C:\Users\Yves\AppData\Local\Temp\tmpv4x9aths\firefox\firefox.exe
2022-06-26T13:20:59.130000: INFO : Application command: C:\Users\Yves\AppData\Local\Temp\tmpv4x9aths\firefox\firefox.exe --wait-for-browser -profile C:\Users\Yves\AppData\Local\Temp\tmpiz29xqw8.mozrunner
2022-06-26T13:20:59.180000: INFO : application_buildid: 20220208215108
2022-06-26T13:20:59.180000: INFO : application_changeset: bad861b891423d17bc93922efdbc5f55588f5e5b
2022-06-26T13:20:59.180000: INFO : application_display_name: Firefox Nightly
2022-06-26T13:20:59.180000: INFO : application_id: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
2022-06-26T13:20:59.181000: INFO : application_name: Firefox
2022-06-26T13:20:59.181000: INFO : application_remotingname: firefox-nightly
2022-06-26T13:20:59.181000: INFO : application_repository: https://hg.mozilla.org/mozilla-central
2022-06-26T13:20:59.181000: INFO : application_vendor: Mozilla
2022-06-26T13:20:59.181000: INFO : application_version: 99.0a1
2022-06-26T13:20:59.181000: INFO : platform_buildid: 20220208215108
2022-06-26T13:20:59.182000: INFO : platform_changeset: bad861b891423d17bc93922efdbc5f55588f5e5b
2022-06-26T13:20:59.182000: INFO : platform_repository: https://hg.mozilla.org/mozilla-central
2022-06-26T13:20:59.182000: INFO : platform_version: 99.0a1
2022-06-26T13:21:02.171000: INFO : b'[Parent 86880, IPC I/O Parent] WARNING: file /builds/worker/checkouts/gecko/ipc/chromium/src/base/process_util_win.cc:167'
2022-06-26T13:21:04.955000: INFO : b'[fluent] Missing message in locale de: update-application-suppress-prompts'
2022-06-26T13:21:08.094000: INFO : Narrowed nightly regression window from [2022-02-07, 2022-02-09] (2 days) to [2022-02-08, 2022-02-09] (1 days) (~0 steps left)
2022-06-26T13:21:08.100000: INFO : The bisection is done.
2022-06-26T13:21:08.101000: INFO : Stopped

The last list item has this content on the right side:

app_name: firefox
build_date: 2022-02-08
build_file: C:\Users\Yves\.mozilla\mozregression\persist\2022-02-08--mozilla-central-l10n--firefox-99.0a1.de.win64.zip
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central-l10n/firefox-99.0a1.de.win64.zip
changeset: bad861b891423d17bc93922efdbc5f55588f5e5b
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bad861b891423d17bc93922efdbc5f55588f5e5b&tochange=76e48e33855f2bacad3301ebe987e46ff65db5cf
repo_name: mozilla-central-l10n
repo_url: https://hg.mozilla.org/mozilla-central

I understand the bisect concept from using Git but I really don't understand what the output of this tool means. Hope this helps.

Comment 8

[Yves Goergen]

Oh, and yes, this definitely is a regression. I need that dialog often to clear the cache when debugging things. I wish there was a "clear cache" menu command that would make things easier and quicker. So I see this dialog every now and then and I'd have reported it much earlier if it was broken from the start.

Comment 9

[:Gijs (he/him)]

(In reply to Yves Goergen from comment #7)

The last list item has this content on the right side:

app_name: firefox
build_date: 2022-02-08
build_file: C:\Users\Yves\.mozilla\mozregression\persist\2022-02-08--mozilla-central-l10n--firefox-99.0a1.de.win64.zip
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2022/02/2022-02-08-21-51-08-mozilla-central-l10n/firefox-99.0a1.de.win64.zip
changeset: bad861b891423d17bc93922efdbc5f55588f5e5b
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bad861b891423d17bc93922efdbc5f55588f5e5b&tochange=76e48e33855f2bacad3301ebe987e46ff65db5cf
repo_name: mozilla-central-l10n
repo_url: https://hg.mozilla.org/mozilla-central

I understand the bisect concept from using Git but I really don't understand what the output of this tool means. Hope this helps.

It does, thank you very much ! The pushlog_url here shows all the commits that landed in that 1-day window.

I checked and it includes bug 1745973, which in Germany (and the UK and France) added some creditcard autofill items to the privacy & security section of the preferences, including some pretty long text that isn't set up to wrap. I expect this is what caused the problem. If you set extensions.formautofill.creditCards.supportedCountries in about:config to UK,CA (ie remove ,GB,FR,DE from the list), and refresh the settings page (you don't even need to fully restart Firefox), can you confirm that that "fixes" the problem locally? (You can revert the pref afterwards so you don't lose creditcard autofill...)

Tim, can we make the "require macOS/Windows authentication" pref allow wrapping? You can look at how automaticallySubmitCrashesBox is set up to see how we could use an HTML checkbox + wrapping text label (with the link included in it). That would probably cure the problem.

Comment 10

[Yves Goergen]

Yes, changing that pref fixes the UI layout for me. I just removed the "DE" part.

I don't need that feature anyway because I don't think the browser is a good place to store credentials or payment data anyway. I have other (cross-browser and cross-device) solutions for that.

Comment 11

[Tim Giles [:tgiles]]

I don't see any issue in allowing the "require macOS/Windows authentication" pref to allow text wrapping, I'll see what I can do.

Comment 12

[berti]

"Yes, changing that pref fixes the UI layout for me. I just removed the "DE" part"
Yes this solved the problem for me too (Firefox 101.0.1)

Comment 13

[Tim Giles [:tgiles]]

Attachment: Bug 1773212 - Fix OS authentication checkbox for credit card autofill not wrapping its text. r=dimi

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/defd1a97b18e
Fix OS authentication checkbox for credit card autofill not wrapping its text. r=sgalich

Comment 15

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/defd1a97b18e

Comment 16

[Ryan VanderMeulen [:RyanVM]]

This seems like a simple fix - is there a reason 103 was set to wontfix?

Comment 17

[:Gijs (he/him)]

(In reply to [Back July 11] Ryan VanderMeulen from comment #16)

This seems like a simple fix - is there a reason 103 was set to wontfix?

I envisaged a different patch that would have entailed localization changes. You're right that this patch could be uplifted. Tim, want to request beta uplift? :-)

Comment 18

[Tim Giles [:tgiles]]

Comment on attachment 9283135 [details]
Bug 1773212 - Fix OS authentication checkbox for credit card autofill not wrapping its text. r=dimi

Beta/Release Uplift Approval Request

• User impact if declined: Low
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): UI change that affects a single element
• String changes made/needed: No
• Is Android affected?: No

Comment 19

[Donal Meehan [:dmeehan]]

Comment on attachment 9283135 [details]
Bug 1773212 - Fix OS authentication checkbox for credit card autofill not wrapping its text. r=dimi

Approved for 103.0b3, thanks.

Comment 20

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/918c910e763d

Comment 21

[Mihai Boldan, Desktop QA [:mboldan]]

Attachment: DE vs en-US.png

We managed to reproduce the issue on Firefox 104.0a1 (2022-07-04), under macOS 10.15.
The issue was verified on Firefox Nightly 104.0a1 (2022-07-04) (64-Bit) and on Firefox 103.0b4, under macOS 10.15, Window 10x64 and under Ubuntu 20.04, on both en-US and DE localizations, with different results.
On the Nightly builds en-US and DE localizations and on Firefox 103.0b4 DE localization the issue doesn't seems to be fixed.
On Firefox 103.0b4 en-US the issue is not reproducible anymore.
Here is a screenshot with the difference between Firefox 103.0b4 en-US build and Firefox 103.04 DE build.
Please let me know if this is expected, or not.

Comment 22

[Tim Giles [:tgiles]]

Given similarly sized windows in both en-US and DE localizations, the spacing of the elements under the "Custom" option of Enhanced Tracking Protection seems to behave as expected IMO. For example, you can recreate the spacing in the en-US screenshot by reducing the width of the DE window and get the "Cookies" dropdown to rest right beside the "Cookies" text. I don't think this is an issue.

Comment 23

[Mihai Boldan, Desktop QA [:mboldan]]

Attachment: Bug 1773212 .gif

Here is a screencast in order for you to see how page elements are reacting on window resize. On Firefox 103 Beta en-US the page elements are reacting in a different way than on Firefox 103 Beta DE build, or from the Nightly builds.
On Firefox Beta 103, the transition is more smoother.

Comment 24

[Tim Giles [:tgiles]]

:Gijs, I'm a bit stumped by this one. Do you have any idea why adding a flex="1" to a completely different section would cause the spacing of the Enchanced Tracking Protection's Custom section to behave differently? I'm not sure why the "Cookies" label is not taking its normal width anymore, causing the spacing issue present in Comment #21.

Comment 25

[:Gijs (he/him)]

(In reply to Tim Giles [:tgiles] from comment #24)

:Gijs, I'm a bit stumped by this one. Do you have any idea why adding a flex="1" to a completely different section would cause the spacing of the Enchanced Tracking Protection's Custom section to behave differently?

flex=1 on the checkbox/container where you used it will mean that it will adapt its width to its container, rather than dictating its width as a minimum width and thus restricting the container from becoming smaller. So you've taken the reauthCheckbox out of the running for determining a minimum width for the container.

The screencast to me doesn't seem like it's showing a difference with the pre-patch state - it just shows the issue isn't fixed yet.

I'm not sure why the "Cookies" label is not taking its normal width anymore, causing the spacing issue present in Comment #21.

That section of the pref pane is still adapting its width to the container as well - it's not that anything changed about the Cookies label, but that the container is still being forced to be a certain width by... something, ie something else (other than the reauth checkbox) is (still) making the container wide.

I'd suggest using mozregression to launch a de-DE l10n build, opening the privacy pref pane, resizing the window to be narrow, and then just using the devtools inspector (probably popped out into its own window) to delete other items in that prefpane until the width of the privacy pane shrinks. Then ctrl-z to undo and see what was the thing you deleted that made a difference, then figure out which thing in that container is not wrapping / has very long text in German.

Comment 26

[Tim Giles [:tgiles]]

Attachment: Bug 1773212 - Fix various elements not correctly wrapping on the privacy pane. r=gijs!

Fixes the total cookie protection label not wrapping when text is long.

Prevents the select dropdown of the 'Cookies' option in the "Custom" mode
of ETP from crashing into the 'Cookies' checkbox.

Fixes the breachAlerts box from not wrapping when the checkbox's text is long.

Fixes the windows-sso box from not wrapping when the checkbox's text is long.

Fixes the alignment of the "Logins and Passwords" subcategory.

Comment 27

[Tim Giles [:tgiles]]

Berti, if you reset the extensions.formautofill.creditCards.supportedCountries pref in about:config to its default value, do you still experience this bug?

Comment 28

[Tim Giles [:tgiles]]

Marking this as fixed, as the original issue of the issue was addressed in https://phabricator.services.mozilla.com/D150426. As for the other issues of elements not wrapping as expected as seen in Comment 21 and Comment 23, I've filed Bug 1793116 as a follow-up.

Feel free to reopen if the issue reappears!

Comment 29

[Ryan VanderMeulen [:RyanVM]]

Should we get this onto ESR102 also? Please nominate if yes.

Comment 30

[Tim Giles [:tgiles]]

Comment on attachment 9283135 [details]
Bug 1773212 - Fix OS authentication checkbox for credit card autofill not wrapping its text. r=dimi

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This fixes a regression in about:preferences when using the German langpack, and most likely other non-English languages. Since credit card autofill is enabled by default in Germany, this regression will affect users who haven't disabled credit card autofill in Germany.
• User impact if declined: An unnecessary horizontal scrollbar may appear in about:preferences#privacy, which may make navigating the page more difficult.
• Fix Landed on Version: 103
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a one line styling fix.

Comment 31

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9283135 [details]
Bug 1773212 - Fix OS authentication checkbox for credit card autofill not wrapping its text. r=dimi

Approved for 102.4esr.

Comment 32

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/367500497c47

Comment 33

[Mihai Boldan, Desktop QA [:mboldan]]

The issue was verified under Windows 10x64 and under macOS 10.15, using Firefox 106.0RC and Firefox 102.4ESR builds.