1773249 - Dragging a contact onto the book it's already in causes the contact to be deleted

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

Somehow the "drop" event is firing even though it shouldn't, and that causes cards to be added to the destination book then deleted from the source book. If they're the same book then the card is deleted.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1773249 - Prevent drop action on address book deleting the dropped card. r=#thunderbird-reviewers

Comment 2

[Geoff Lankow (:darktrojan)]

I think the cause is something to do with a "dragover" handler outside the address book browser, or maybe on the browser itself. That might be confusing the code into thinking there is a valid drop target when there isn't. It's hard to tell.

Comment 3

[Wayne Mery (:wsmwk)]

Assuming this affects 102. If not, please update the flags. Thanks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f64404889698
Prevent drop action on address book deleting the dropped card. r=thunderbird-reviewers,freaktechnik

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9280222 [details]
Bug 1773249 - Prevent drop action on address book deleting the dropped card. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): new AB
User impact if declined: (small) potential for data loss
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9280222 [details]
Bug 1773249 - Prevent drop action on address book deleting the dropped card. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/f40b84f044ed