1773480 - Swap frame pointer and stub pointer in BaselineStub frames

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

We currently push the return address, stub pointer and caller frame pointer. For external stack unwinders it would be less confusing if we switched the last two.

This also gets us closer to adding the caller frame pointer to the CommonFrameLayout.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1773480 part 1 - Use GetPreviousRawFrame for BaselineStub frames too. r?iain!

This is more consistent with what we do for the other frame types.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1773480 part 2 - Remove JitStubFrameLayout. r?iain!

This was added for the old shared-stubs mechanism for Ion stubs.

Depends on D148777

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1773480 part 3 - Swap stub pointer and frame pointer in BaselineStub frames. r?iain!

The frame pointer is now pushed immediately after the return address, to help
native stack unwinders.

The main problem here was that STUB_FRAME_SIZE now has to be split in StubFrameSize and
StubFrameSizeFromFP because the latter now doesn't have to skip the stub pointer.

Depends on D148778

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf7b37cb46c2
part 1 - Use GetPreviousRawFrame for BaselineStub frames too. r=iain
https://hg.mozilla.org/integration/autoland/rev/9b3a441d5bd1
part 2 - Remove JitStubFrameLayout. r=iain
https://hg.mozilla.org/integration/autoland/rev/c355076e750f
part 3 - Swap stub pointer and frame pointer in BaselineStub frames. r=iain

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bf7b37cb46c2
https://hg.mozilla.org/mozilla-central/rev/9b3a441d5bd1
https://hg.mozilla.org/mozilla-central/rev/c355076e750f