1773648 - Rewrite the profiler exit-frame-stub to use frame pointers

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

JitRuntime::generateProfilerExitFrameTailStub can be greatly simplified now that we have frame pointers. This also gets us closer to removing the frame size from the frame descriptor.

The new implementation is also shared instead of mostly-duplicated for each platform:

12 files changed, 246 insertions(+), 2584 deletions(-)

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1773648 part 1 - Add frame pointer to IonICCall frames. r?iain!

This is required for the next patch, and gets us one step closer to having the caller's
frame pointer in every JIT frame.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1773648 part 2 - Rewrite profiler exit-frame-stub to use frame pointers instead of frame descriptors. r?iain!

This is a lot simpler and gets rid of another dependency on the frame descriptor's
frame size. Once the frame pointer is stored in the frame layout, this can be simplified
more because we still have to add FPOffset in a number of places.

A lot of complexity in the old version came from supporting rectifier frames. The
new approach is to "unwrap" the rectifier frame and then restart at the next frame.

This also de-duplicates the implementation.

Depends on D148895

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e28d9c44359c
part 1 - Add frame pointer to IonICCall frames. r=iain
https://hg.mozilla.org/integration/autoland/rev/df60cd30dfe9
part 2 - Rewrite profiler exit-frame-stub to use frame pointers instead of frame descriptors. r=iain

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e28d9c44359c
https://hg.mozilla.org/mozilla-central/rev/df60cd30dfe9