Closed Bug 1773671 Opened 3 years ago Closed 2 years ago

7.92 - 0.09% build times / installer size + 2 more (OSX) regression on Tue June 7 2022

Categories

(Data Platform and Tools :: Glean: SDK, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: aesanu, Unassigned)

References

(Regression)

Details

(Keywords: perf-alert, regression)

Perfherder has detected a build_metrics performance regression from push bdfb6d899e3f3a4103e5a57e462265bc6b723369. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
8% build times macosx64 buildbot-unknown rusttests 587.26 -> 633.77
0.27% installer size osx-aarch64-shippable aarch64 nightly 81,019,463.84 -> 81,235,922.25
0.24% installer size osx-shippable nightly 83,315,376.08 -> 83,518,597.58
0.09% installer size osx-shippable instrumented 119,340,822.07 -> 119,445,945.50

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Installer size increases are hopefully small enough to not be problematic.
8% slower builds for rusttests though is significant. This can be explained by the bunch of dependencies we introduced to the build. This is hard to avoid. We are using tooling that's shared with others (application-services), who are also in the process of landing more of their work in-tree, so really this is unavoidable.
A backout would cause ripple effects in Fenix and Focus, as they depend on the newly shipped code already.

We can make it a task to look into possibilities of cutting down dependencies/build times, but of course I cannot guarantee anything about that (we already only include what we need)

Priority: -- → P3
Priority: P3 → P4

This was 2 years ago and lots happened since then. I'm going to close this.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.