1773678 - Dropmarkers invisible

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Martin Giger [:freaktechnik]]

https://hg.mozilla.org/comm-central/rev/f0bdf121c3132436c8abd861a47cd0a2a744992d changed the dropmarker SVG (though the follow up actually fixed it). This leads to the dropmarker in many places accross the application being invisible, since the old icon used a fill context property and the new one uses stroke. Some choice locations:

• Dropdowns/selects in the address book editor
• Dropdowns/selects in account and application settings
• Tree collapse markers in account manager
• Account actions menu in account manager
• Encryption menu in chat 1:1 conversations

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1773678 - Apply the stroke to all arrow icon places. r=aleca

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1773678 - Add for the override icons a "context-fill" path to be used from toolkit styles. r=aleca

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2ea342ef2624
Apply the stroke to all arrow icon places. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9280693 [details]
Bug 1773678 - Apply the stroke to all arrow icon places. r=aleca

[Approval Request Comment]
Regression caused by (bug #): bug 1768505
User impact if declined: some arrow icons aren't visible
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9280693 [details]
Bug 1773678 - Apply the stroke to all arrow icon places. r=aleca

[Triage Comment]
Approved for beta

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2285e873c247
Add for the override icons a "context-fill" color option to be used from toolkit styles. r=aleca

Comment 9

[Martin Giger [:freaktechnik]]

While that last patch did make the check marks visible again in the (account) settings, they are now black instead of white.

Comment 10

[Rob Lemley [:rjl]]

I need clarification on what to uplift. Comment 3 applies to beta with minor complaints, comment 8 does not apply. Is there an intermediate patch that's needed?

Comment 11

[Richard Marti (:Paenglab)]

(In reply to Rob Lemley [:rjl] from comment #10)

I need clarification on what to uplift. Comment 3 applies to beta with minor complaints, comment 8 does not apply. Is there an intermediate patch that's needed?

From bug 1768505 the attachment 9280537 [details] needs an uplift too. Then the patch would apply.

Comment 12

[Magnus Melin [:mkmelin]]

Will back out https://hg.mozilla.org/comm-central/rev/2285e873c247 next landing

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e00b3fe25e4c
Backed out changeset 2285e873c247 pre developer request. rs=backout

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a5581fdc924c
Add for the override icons a "context-fill" path to be used from toolkit styles. r=aleca

Comment 15

[Richard Marti (:Paenglab)]

Comment on attachment 9280736 [details]
Bug 1773678 - Add for the override icons a "context-fill" path to be used from toolkit styles. r=aleca

[Approval Request Comment]
Regression caused by (bug #): 1768505
User impact if declined: some icons that come from toolkit invisible
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, when the last patch from bug 1768505 is uplifted first

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 102.0beta6:
https://hg.mozilla.org/releases/comm-beta/rev/a660be9474ce
Thunderbird 102.0beta6:
https://hg.mozilla.org/releases/comm-beta/rev/bfe3e15a4cd5

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9280736 [details]
Bug 1773678 - Add for the override icons a "context-fill" path to be used from toolkit styles. r=aleca

[Triage Comment]
Approved for beta (but already landed)