1773747 - Detect lazy getter immediately used in the top-level script

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Tooru Fujisawa [:arai]]

If lazy getter is immediately used at the top-level script unconditionally, it doesn't have to be lazy getter.

https://searchfox.org/mozilla-central/rev/97c13320e56884daf14016048e9d2182c880f8a9/remote/cdp/domains/content/Runtime.jsm#14-17,24,32-33

const lazy = {};

XPCOMUtils.defineLazyModuleGetters(lazy, {
  addDebuggerToGlobal: "resource://gre/modules/jsdebugger.jsm",
...
});
...
// Import the `Debugger` constructor in the current scope
lazy.addDebuggerToGlobal(globalThis);

Comment 1

[Tooru Fujisawa [:arai]]

this can be added to the rule in bug 1771173

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773747 - Part 6: Add ESLint rule to check immediately-used lazy getter. r?Standard8!

Comment 3

[Tooru Fujisawa [:arai]]

the patch is based on bug 1771173

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773747 - Part 1: Do not use lazy getter for immediately-used symbol in browser/components/. r?Gijs!

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773747 - Part 2: Do not use lazy getter for immediately-used symbol in services/. r?markh!

Depends on D149986

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773747 - Part 3: Do not use lazy getter for immediately-used symbol in toolkit/components/nimbus/. r?barret!

Depends on D149987

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773747 - Part 4: Do not use lazy getter for immediately-used symbol in toolkit/components/search/. r?mcheang!

Depends on D149988

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773747 - Part 5: Do not use lazy getter for immediately-used symbol in XPIDatabase.jsm. r?kmag!

Depends on D149989

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3956d4c17fa6
Part 1: Do not use lazy getter for immediately-used symbol in browser/components/. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/8095b64db691
Part 2: Do not use lazy getter for immediately-used symbol in services/. r=markh
https://hg.mozilla.org/integration/autoland/rev/e179ce03de58
Part 3: Do not use lazy getter for immediately-used symbol in toolkit/components/nimbus/. r=barret
https://hg.mozilla.org/integration/autoland/rev/8b5616c36e0f
Part 4: Do not use lazy getter for immediately-used symbol in toolkit/components/search/. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/ea025a943cb5
Part 5: Do not use lazy getter for immediately-used symbol in XPIDatabase.jsm. r=kmag
https://hg.mozilla.org/integration/autoland/rev/060cc066304c
Part 6: Add ESLint rule to check immediately-used lazy getter. r=Standard8

Comment 10

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/3956d4c17fa6
https://hg.mozilla.org/mozilla-central/rev/8095b64db691
https://hg.mozilla.org/mozilla-central/rev/e179ce03de58
https://hg.mozilla.org/mozilla-central/rev/8b5616c36e0f
https://hg.mozilla.org/mozilla-central/rev/ea025a943cb5
https://hg.mozilla.org/mozilla-central/rev/060cc066304c