1771173 - Add a rule/detection for invalid accesses of modules when using ChromeUtils.defineLazyESModuleGetters

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

With moving to ESM modules, we are planning on defining a new system for lazy getters:

let lazy = {};
ChromeUtils.defineLazyESModuleGetters(lazy, {
  MyService: "MyService.sys.mjs",
});

// Access
lazy.MyService.add(1);

Whilst ESLint will automatically detect the lazy variable, I think we should be able to extend it to know what is available within lazy and report invalid accesses.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1771173 - Fix/ignore some duplicate imports caught by the new valid-lazy rule. r?arai

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1771173 - Rework FormAutoFill's log creation to make it easier for linters to handle. r?sgalich

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1771173 - Make XPIDatabase/XPIInstall lazy getters easier to work with linters. r?#extension-reviewers

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1771173 - Add ESLint rule to check for correct usages of lazy. r?arai

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1771173 - Clean up unused definitions of console in extension modules. r?#extension-reviewers

Depends on D149717

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1771173 - Remove unused imports. r?arai!,#geckoview-reviewers

Depends on D149785

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/542f213b208f
Fix/ignore some duplicate imports caught by the new valid-lazy rule. r=arai
https://hg.mozilla.org/integration/autoland/rev/e270b8b7f8bd
Rework FormAutoFill's log creation to make it easier for linters to handle. r=sgalich
https://hg.mozilla.org/integration/autoland/rev/b1415a0f03a0
Make XPIDatabase/XPIInstall lazy getters easier to work with linters. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/fe89c8b44d12
Clean up unused definitions of console in extension modules. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/ad6ec35d0534
Remove unused imports. r=geckoview-reviewers,arai,owlish
https://hg.mozilla.org/integration/autoland/rev/eb2616c17dd6
Add ESLint rule to check for correct usages of lazy. r=arai

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/542f213b208f
https://hg.mozilla.org/mozilla-central/rev/e270b8b7f8bd
https://hg.mozilla.org/mozilla-central/rev/b1415a0f03a0
https://hg.mozilla.org/mozilla-central/rev/fe89c8b44d12
https://hg.mozilla.org/mozilla-central/rev/ad6ec35d0534
https://hg.mozilla.org/mozilla-central/rev/eb2616c17dd6