1773752 - Remove workarounds for old SDK versions once macOS 11 SDK is required by configure (bug 1696513)

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P2)

Description

[Stephen A Pohl [:spohl]]

We can remove existing workarounds for old SDKs once bug 1696513 lands, i.e. any code that's only needed for old SDKs..

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Bug 1773752: Remove workarounds for old macOS SDKs and update documentation. r=mstange

Depends on D148933

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6628f146ad0b
Remove workarounds for old macOS SDKs and update documentation. r=mstange

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing build bustages. CLOSED TREE

Backout link
Push with failures
Link to failure log
Failure line : /builds/worker/checkouts/gecko/gfx/thebes/gfxMacUtils.cpp:16:14: error: 'kCVImageBufferTransferFunction_sRGB' is only available on macOS 10.13 or newer [-Werror,-Wunguarded-availability-new]

Link to failure log 2
Failure line : python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py::OSXToolchainTest::test_clang TEST-UNEXPECTED-FAIL

Comment 4

[Stephen A Pohl [:spohl]]

Unfortunately, it looks like we can't remove all these workarounds just yet because our deployment target remains 10.12... :-/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7720fa81b26
Remove workarounds for old macOS SDKs and update documentation. r=mstange

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c7720fa81b26

Comment 7

[Stephen A Pohl [:spohl]]

We discussed this bug in the macOS Spotlight meeting today and we believe we can remove more code. I'll take a look this week.

Comment 8

[Stephen A Pohl [:spohl]]

Attachment: Bug 1773752: Remove more workarounds for old macOS SDKs. r=mstange

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76918c8b1adc
Remove more workarounds for old macOS SDKs. r=mstange,media-playback-reviewers,padenot

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/76918c8b1adc