1774081 - `Edit list` menuitem label from mailing list context regressed to `Properties`, reducing discoverability

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect, P3)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Find the odd one out: Properties!

Discovering how to edit a mailing list is non-trivial, and took me quite long (stuff for another bug: Double-click fails, Enter fails, no Edit button in the UI, and if you happen to select your mailing list item inside the contacts list, there's no way of editing at all).

For starters, I see no reason to why the natural language action string Edit List has been changed back to abstract Properties. We once had that and intentionally got rid of it (see Bug 1310442).

Edit (or Edit List) is

• less technical, more natural, more intuitive, more discoverable
• more action-oriented, which is good practice and ux-consistent with
  • all the other items on mailing list context which are action verbs, not abstract nouns
  • the dialog title: Edit <list name>

Implementation notes

• I recall this may need a dynamic string because the underlying command is cmd_properties, which also applies to address book items in the directory pane, for which we want to keep "Properties".
• Personally, I find Edit List quite alright, but we'd probably want just Edit for the new Fluent string.
• If we believe we cannot create this in Fluent because of string freeze (I wonder how we'd fix wrong strings after the freeze?), we could restore the strings for Edit List from localized dtd or properties files.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: Bug 1774081 - Show Edit list in the address book context menus for lists. r=darktrojan

Comment 2

[Alessandro Castellani [:aleca]]

Waiting for the try run before marking this for check-in: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=98917ed7d508b8848afd614af276a6cb5b5ad677

Comment 3

[Alessandro Castellani [:aleca]]

Linting fixed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/54a94c300682
Show Edit list in the address book context menus for lists. r=darktrojan