1774302 - Make VideoFrame Serializable

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, task, P1)

Description

[C.M.Chang[:chunmin]]

After VideoFrame is implemented (bug 1774300), we need to make it Serializable (in .webidl)

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1774302 - Add [Serializable] to VideoFrame

This patch add Serializable attribute to VideoFrame and add some
necessary changes to make this buildable.

Some expectations of video-frame-serialization.any.is's wpts are
changed to PASS since they are implemented in bug 1774300.

The Verify posting closed frames throws is currently passed by luck so
the its expectation stays the same.

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1774302 - Implement [Serializable] for VideoFrame

This patch implements {Read, Write}StructuredClone for VideoFrame so
VideoFrame can be {de,}serialized.

Depends on D153685

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1774302 - Add missing thread-safety checks

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1774302 - Add a wpt posting VideoFrame across agent cluster boundaries

Depends on D153686

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1774302 - Ensure videoframe serialization is same-origin

By using --disable-e10s, VideoFrame can be serialized in same process
but in different origins. To prevent the VideoFrame from being passed
across different origins, origins should be checked before constructing
a VideoFrame.

Depends on D159546

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1774302 - Add a wpt passing VideoFrame between main and worker

Depends on D159546

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7328aadd86e9
Add missing thread-safety checks r=padenot
https://hg.mozilla.org/integration/autoland/rev/0009cdcc3e11
Add [Serializable] to VideoFrame r=padenot,smaug
https://hg.mozilla.org/integration/autoland/rev/3db9d390aa0d
Implement [Serializable] for VideoFrame r=padenot,smaug
https://hg.mozilla.org/integration/autoland/rev/5a2fc97cac78
Add a wpt posting VideoFrame across agent cluster boundaries r=padenot,smaug
https://hg.mozilla.org/integration/autoland/rev/b94e43f1e91f
Add a wpt passing VideoFrame between main and worker r=smaug
https://hg.mozilla.org/integration/autoland/rev/6ff613ee0977
Ensure videoframe serialization is same-origin r=smaug

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36672 for changes under testing/web-platform/tests

Comment 9

[Marian-Vasile Laza]

Backed out 6 changesets (Bug 1774302) for causing bustages on VideoFrame.cpp.
Backout link
Push with failures <--> H
Failure Log

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[C.M.Chang[:chunmin]]

Attachment: Bug 1774302 - Fix unrooted return value in VideoFrame deserialization

To avoid an rooting hazard error from returning a raw JSObject* before
running the RefPtr<VidoeFrame>'s destructor, the RefPtr<VideoFrame>
needs to be destroyed before returning the raw JSObject*

Depends on D160155

Comment 12

[C.M.Chang[:chunmin]]

D160561 should be able to fix the hazard issue.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a91b2c948b8d
Add missing thread-safety checks r=padenot
https://hg.mozilla.org/integration/autoland/rev/89993b673e0f
Add [Serializable] to VideoFrame r=padenot,smaug
https://hg.mozilla.org/integration/autoland/rev/2deaf376e1b8
Implement [Serializable] for VideoFrame r=padenot,smaug
https://hg.mozilla.org/integration/autoland/rev/ac7ae2db38ed
Add a wpt posting VideoFrame across agent cluster boundaries r=padenot,smaug
https://hg.mozilla.org/integration/autoland/rev/5b95b1a7c673
Add a wpt passing VideoFrame between main and worker r=smaug
https://hg.mozilla.org/integration/autoland/rev/e880fd8436cc
Ensure videoframe serialization is same-origin r=smaug
https://hg.mozilla.org/integration/autoland/rev/8399201e3b08
Fix unrooted return value in VideoFrame deserialization r=sfink

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a91b2c948b8d
https://hg.mozilla.org/mozilla-central/rev/89993b673e0f
https://hg.mozilla.org/mozilla-central/rev/2deaf376e1b8
https://hg.mozilla.org/mozilla-central/rev/ac7ae2db38ed
https://hg.mozilla.org/mozilla-central/rev/5b95b1a7c673
https://hg.mozilla.org/mozilla-central/rev/e880fd8436cc
https://hg.mozilla.org/mozilla-central/rev/8399201e3b08

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot