1797205 - WPT test pages in different origin should be in different processes

Status: RESOLVED INVALID

(Core :: DOM: Content Processes, enhancement, P2)

Description

[C.M.Chang[:chunmin]]

D159546 adds a wpt to check the VideoFrame cannot be posted across processes. Surprisingly, the test results in try server show that the WPT pages in different origins are actually in the same process on webrender-enabled Linux and Android machines. IIUC, fission should isolate the pages into the processes dedicated to their origins.

Comment 1

[C.M.Chang[:chunmin]]

I am not able to reproduce this locally by setting both gfx.webrender.all and fission.autostart to true so it's possible that some settings in CI make that test failed (e.g., using --disable-e10s).

Comment 2

[Timothy Nikkel (:tnikkel)]

Webrender is always enabled now (there is only webrender), so DOM: Content Processes might be a better place to start this.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Android doesn't use fission by default, and will only use separate processes if it believes you've logged into the site in the past, IIRC.

It may be possible to force android to use strict fission via a pref.

Comment 4

[C.M.Chang[:chunmin]]

(In reply to Randell Jesup [:jesup] (needinfo me) from comment #3)

Android doesn't use fission by default, and will only use separate processes if it believes you've logged into the site in the past, IIRC.

What's the status for Linux? From the test result, the WPT pages in different origins are in the same process on Linux 18.04 x64 WebRender debug machine. Is that expected?

Comment 5

[Jens Stutte [:jstutte]]

(In reply to C.M.Chang[:chunmin] from comment #4)

(In reply to Randell Jesup [:jesup] (needinfo me) from comment #3)

Android doesn't use fission by default, and will only use separate processes if it believes you've logged into the site in the past, IIRC.

What's the status for Linux? From the test result, the WPT pages in different origins are in the same process on Linux 18.04 x64 WebRender debug machine. Is that expected?

Looking at https://treeherder.mozilla.org/jobs?repo=try&revision=a79cca2d2a75914166164811671fdd562550a448&selectedTaskRun=F8mvStGcShu6XeOV4PrFdg.0 the test seems to fail for linux only when nofis (that is: no fission enabled) ?

Comment 6

[C.M.Chang[:chunmin]]

(In reply to Jens Stutte [:jstutte] from comment #5)

Looking at https://treeherder.mozilla.org/jobs?repo=try&revision=a79cca2d2a75914166164811671fdd562550a448&selectedTaskRun=F8mvStGcShu6XeOV4PrFdg.0 the test seems to fail for linux only when nofis (that is: no fission enabled) ?

Aha, that explains.

Comment 7

[Nika Layzell [:nika] (ni? for response)]

(In reply to Randell Jesup [:jesup] (needinfo me) from comment #3)

Android doesn't use fission by default, and will only use separate processes if it believes you've logged into the site in the past, IIRC.

We don't have even that mode of fission enabled for android yet by default. There are some tests which are run with android fission though. If you need to know about the status of android fission, I'd probably ping :chutten.

The pref to enable is the usual fission.autostart = true and fission.webContentIsolationStrategy = 1 (IsolateEverything https://searchfox.org/mozilla-central/rev/59f0bf3c13dd455d9f5415b89178de701ea6b850/dom/ipc/ProcessIsolation.cpp#62)

Comment 8

[C.M.Chang[:chunmin]]

I am going to close this bug since (1) fission is not yet supported in Android by default (2) nofis means "no fission"

Comment 9

[Emilio Cobos Álvarez [:emilio]]

We should probably behave the same way regardless of process isolation? As in, the test should ideally fail even with fission disabled.

Comment 10

[C.M.Chang[:chunmin]]

D160155 has been added to make sure the test behaves the same even when fission is disabled.