Closed Bug 1774435 Opened 2 years ago Closed 2 years ago

Remove NIGHTLY_BUILD conditions for Firefox View

Categories

(Firefox :: Firefox View, task, P2)

task
Points:
2

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox103 --- disabled
firefox104 --- disabled
firefox105 --- disabled
firefox106 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-firefox-view])

Attachments

(1 file)

(dao) How do we make sure we catch all NIGHTLY_BUILD ifdefs when we want Firefox View to ride trains? I'm adding another one in browser-menubar.inc here: https://phabricator.services.mozilla.com/D149367
(gijs) yeah, I just added another one as well, and was wondering the same. My best guess is making sure we track all the bugs in the fx-view deptree on bugzilla and then creating a list from those but it still sounds tedious
(dao) @gijs how about we add a feature specific alias that defaults to NIGHTLY_BUILD? Doesn't help with chasing these down now, but at least we won't need to do that at the last minute
(gijs) @dao sgtm, not sure how easy it is to do that so it works everywhere, but I guess that can be a separate problem.

Severity: -- → N/A
Priority: -- → P2
Blocks: 1771311
See Also: → 1774927
Component: General → Firefox View
See Also: → 1782723

At this point I think we should just remove these.

Summary: Replace NIGHTLY_BUILD ifdefs with a feature-specific condition → Remove NIGHTLY_BUILD ifdefs for Firefox View
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Points: --- → 2
Attachment #9289465 - Attachment description: Bug 1774435 - Remove NIGHTLY_BUILD ifdefs for Firefox View. r=gijs → Bug 1774435 - Remove NIGHTLY_BUILD conditions for Firefox View. r=gijs
Summary: Remove NIGHTLY_BUILD ifdefs for Firefox View → Remove NIGHTLY_BUILD conditions for Firefox View
No longer blocks: 1771311
Attachment #9289465 - Attachment description: Bug 1774435 - Remove NIGHTLY_BUILD conditions for Firefox View. r=gijs → WIP: Bug 1774435 - Remove NIGHTLY_BUILD conditions for Firefox View.
Blocks: 1785244
Regressed by: 1785244
No longer regressed by: 1785244

Was this supposed to have landed in 105 so that about:firefoxview could be tested on beta after flipping a pref?

(In reply to Ed Lee :Mardak from comment #3)

Was this supposed to have landed in 105 so that about:firefoxview could be tested on beta after flipping a pref?

Not that I know. In my estimation development is still active enough that beta would become too much of an outdated testing ground to be useful soon after splitting from m-c. Or is this something that would have been useful for onboarding?

Flags: needinfo?(edilee)
Attachment #9289465 - Attachment description: WIP: Bug 1774435 - Remove NIGHTLY_BUILD conditions for Firefox View. → Bug 1774435 - Remove NIGHTLY_BUILD conditions for Firefox View.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f5bc1560d7d
Remove NIGHTLY_BUILD conditions for Firefox View. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

I believe QA was expecting to be able to test MR features in 105 beta, so not something specific to onboarding. But I'm unclear if there's much benefit in doing so as you pointed out 106 nightly will have additional changes.

Separately, we noticed mach try not running any browser/components/firefoxview tests unless directly specifying the path with mach try fuzzy browser/components/firefoxview but the patch for this bug indeed gets plain try runs without a path correctly running firefoxview tests now.

Flags: needinfo?(edilee)
See Also: → 1786962
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: