1774435 - Remove NIGHTLY_BUILD conditions for Firefox View

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P2)

Description

[Dão Gottwald [:dao]]

(dao) How do we make sure we catch all NIGHTLY_BUILD ifdefs when we want Firefox View to ride trains? I'm adding another one in browser-menubar.inc here: https://phabricator.services.mozilla.com/D149367
(gijs) yeah, I just added another one as well, and was wondering the same. My best guess is making sure we track all the bugs in the fx-view deptree on bugzilla and then creating a list from those but it still sounds tedious
(dao) @gijs how about we add a feature specific alias that defaults to NIGHTLY_BUILD? Doesn't help with chasing these down now, but at least we won't need to do that at the last minute
(gijs) @dao sgtm, not sure how easy it is to do that so it works everywhere, but I guess that can be a separate problem.

Comment 1

[Dão Gottwald [:dao]]

At this point I think we should just remove these.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1774435 - Remove NIGHTLY_BUILD conditions for Firefox View.

Comment 3

[Ed Lee :Mardak]

Was this supposed to have landed in 105 so that about:firefoxview could be tested on beta after flipping a pref?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Ed Lee :Mardak from comment #3)

Was this supposed to have landed in 105 so that about:firefoxview could be tested on beta after flipping a pref?

Not that I know. In my estimation development is still active enough that beta would become too much of an outdated testing ground to be useful soon after splitting from m-c. Or is this something that would have been useful for onboarding?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f5bc1560d7d
Remove NIGHTLY_BUILD conditions for Firefox View. r=sfoster

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8f5bc1560d7d

Comment 7

[Ed Lee :Mardak]

I believe QA was expecting to be able to test MR features in 105 beta, so not something specific to onboarding. But I'm unclear if there's much benefit in doing so as you pointed out 106 nightly will have additional changes.

Separately, we noticed mach try not running any browser/components/firefoxview tests unless directly specifying the path with mach try fuzzy browser/components/firefoxview but the patch for this bug indeed gets plain try runs without a path correctly running firefoxview tests now.