Open Bug 1786962 Opened 2 years ago Updated 2 years ago

Firefox View tests were not run when the component was conditionally built for nightly

Categories

(Developer Infrastructure :: Try, defect, P3)

x86_64
macOS

Tracking

(Not tracked)

People

(Reporter: Mardak, Unassigned)

References

Details

As noted in bug 1774435 comment 7, browser/components/firefoxview used to be conditionally built:

browser/components/moz.build

if CONFIG["NIGHTLY_BUILD"]:
  DIRS += [
    "firefoxview",

And conditionally tested:

browser/components/firefoxview/tests/browser/browser.ini

run-if = nightly_build

and maybe something related to that prevented try from running any tests under browser/components/firefoxview unless directly specified, e.g., ./mach try fuzzy browser/components/firefoxview

For example, this try push for bug 1782524 seemed fine with no firefoxview tests failing in bc1-16, but it's because they didn't actually run:
https://treeherder.mozilla.org/jobs?repo=try&revision=50b9b2925babb41a43d982a030f5d258f5200981

With bug 1774435 landed removing the conditional, this is no longer an issue for the firefoxview component, so mainly tracking this in case other teams end up trying to debug a similar situation.

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(ahal)
Severity: -- → S3
Flags: needinfo?(ahal)
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.