1774696 - Fix layout of the special date field

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Alessandro Castellani [:aleca]]

The "Special Dates" field in the new Address Book edit view is not properly aligned, with the most noticeable issue being the year number input on a second line.

Another issues is the fact that the "month" and "day" labels are selectable in the dropdown, which is just a mistake.

Comment 1

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Another issue are wrong values, examples:

Year  Month  Day    Result
2000  n/a    1   -> 2000----01
3     2      1   -> 03-0-2--01

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Bug 1774696 - Fix layout of the special date field. r=darktrojan,Paenglab

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/88da731814c9
Fix layout of the special date field. r=darktrojan,Paenglab

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9281734 [details]
Bug 1774696 - Fix layout of the special date field. r=darktrojan,Paenglab

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: The horizontal and vertical views of the contacts list don't respect the density changes, and the horizontal layout doesn't look very polished
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): it should be low as the changes applied are purely visual

Comment 5

[Wayne Mery (:wsmwk)]

deferring beta uplift, to include bug 1779100

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #5)

deferring beta uplift, to include bug 1779100

Still deferring

Comment 7

[Wayne Mery (:wsmwk)]

This missed beta uplift, so it will appear in beta 104 with the next esr opportunity being 102.1.1

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9281734 [details]
Bug 1774696 - Fix layout of the special date field. r=darktrojan,Paenglab

[Triage Comment]
Approved for esr102

Comment 9

[Rob Lemley [:rjl]]

looks like this depends on changes from bug 1776372 - is that okay to uplift?

Comment 10

[Alessandro Castellani [:aleca]]

Yes, it should be good

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 102.1.1:
https://hg.mozilla.org/releases/comm-esr102/rev/eba02bce2887