1774933 - Perma [tier 2] /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html | SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ccozmuta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=381796711&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bw_6PnzuRfSVR9sv6PyKrQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-06-18T15:15:45.208Z] 15:15:45     INFO - TEST-START | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html
[task 2022-06-18T15:15:45.209Z] 15:15:45     INFO - Closing window c4ba58fa-3974-4543-a6da-ac1dc50aba7a
[task 2022-06-18T15:15:53.494Z] 15:15:53     INFO - PID 5396 | JavaScript error: http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d3), line 1: SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-06-18T15:15:55.517Z] 15:15:55     INFO - PID 5396 | JavaScript error: http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d2), line 1: SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-06-18T15:15:55.529Z] 15:15:55     INFO - TEST-UNEXPECTED-ERROR | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html | SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-06-18T15:15:55.529Z] 15:15:55     INFO - @http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d3):1:10
[task 2022-06-18T15:15:55.529Z] 15:15:55     INFO - TEST-INFO took 10329ms
[task 2022-06-18T15:15:55.531Z] 15:15:55     INFO - PID 5396 | 1655565355528	Marionette	INFO	Stopped listening on port 52249
[task 2022-06-18T15:15:55.601Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46c200 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3607
[task 2022-06-18T15:15:55.616Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46c200 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1808
[task 2022-06-18T15:15:55.617Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74daf6b00 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3607
[task 2022-06-18T15:15:55.618Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74daf6b00 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1808
[task 2022-06-18T15:15:55.619Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46a400 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3607
[task 2022-06-18T15:15:55.619Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46a400 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1808
[task 2022-06-18T15:15:55.621Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46c200 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1843
[task 2022-06-18T15:15:55.622Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46c200 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3709
[task 2022-06-18T15:15:55.623Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74daf6b00 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1843
[task 2022-06-18T15:15:55.624Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74daf6b00 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3709
[task 2022-06-18T15:15:55.625Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46a400 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1843
[task 2022-06-18T15:15:55.626Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46a400 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3709
[task 2022-06-18T15:15:56.002Z] 15:15:56     INFO - Browser exited with return code 0
[task 2022-06-18T15:15:56.007Z] 15:15:56     INFO - Closing logging queue
[task 2022-06-18T15:15:56.007Z] 15:15:56     INFO - queue closed
[task 2022-06-18T15:15:56.334Z] 15:15:56     INFO - Application command: Z:\task_165555813529169\build\application\firefox\firefox.exe -marionette about:blank --wait-for-browser -profile C:\Users\task_165555813529169\AppData\Local\Temp\tmp_z01hwd3
[task 2022-06-18T15:15:56.354Z] 15:15:56     INFO - PID 4264 | 1655564651233	Marionette	INFO	Marionette enabled
[task 2022-06-18T15:15:56.355Z] 15:15:56     INFO - PID 4264 | 1655564651236	Marionette	INFO	Listening on port 52260
[task 2022-06-18T15:15:56.356Z] 15:15:56     INFO - PID 4264 | JavaScript error: resource://gre/modules/XULStore.jsm, line 68: Error: Can't find profile directory.
[task 2022-06-18T15:15:56.357Z] 15:15:56     INFO - PID 4264 | console.warn: SearchSettings: "get: No settings file exists, new profile?" (new NotFoundError("Could not open the file at C:\\Users\\task_165555813529169\\AppData\\Local\\Temp\\tmpr96kce3i\\search.json.mozlz4", (void 0)))
[task 2022-06-18T15:15:56.358Z] 15:15:56     INFO - PID 4264 | 1655565161310	addons.xpi	ERROR	System addon update list error Error: Failed downloading XML, status: 0, reason: error
[task 2022-06-18T15:15:56.358Z] 15:15:56     INFO - Starting runner
[task 2022-06-18T15:15:57.283Z] 15:15:57     INFO - TEST-START | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-2.html

Comment 1

[o0luuquocviet0o]

(In reply to Treeherder Bug Filer from comment #0)

Filed by: ccozmuta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=381796711&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bw_6PnzuRfSVR9sv6PyKrQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-06-18T15:15:45.208Z] 15:15:45     INFO - TEST-START | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html
[task 2022-06-18T15:15:45.209Z] 15:15:45     INFO - Closing window c4ba58fa-3974-4543-a6da-ac1dc50aba7a
[task 2022-06-18T15:15:53.494Z] 15:15:53     INFO - PID 5396 | JavaScript error: http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d3), line 1: SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-06-18T15:15:55.517Z] 15:15:55     INFO - PID 5396 | JavaScript error: http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d2), line 1: SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-06-18T15:15:55.529Z] 15:15:55     INFO - TEST-UNEXPECTED-ERROR | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html | SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-06-18T15:15:55.529Z] 15:15:55     INFO - @http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d3):1:10
[task 2022-06-18T15:15:55.529Z] 15:15:55     INFO - TEST-INFO took 10329ms
[task 2022-06-18T15:15:55.531Z] 15:15:55     INFO - PID 5396 | 1655565355528	Marionette	INFO	Stopped listening on port 52249
[task 2022-06-18T15:15:55.601Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46c200 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3607
[task 2022-06-18T15:15:55.616Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46c200 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1808
[task 2022-06-18T15:15:55.617Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74daf6b00 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3607
[task 2022-06-18T15:15:55.618Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74daf6b00 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1808
[task 2022-06-18T15:15:55.619Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46a400 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3607
[task 2022-06-18T15:15:55.619Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46a400 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1808
[task 2022-06-18T15:15:55.621Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46c200 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1843
[task 2022-06-18T15:15:55.622Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46c200 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3709
[task 2022-06-18T15:15:55.623Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74daf6b00 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1843
[task 2022-06-18T15:15:55.624Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74daf6b00 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3709
[task 2022-06-18T15:15:55.625Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46a400 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1843
[task 2022-06-18T15:15:55.626Z] 15:15:55     INFO - PID 5396 | [Parent 3652, Main Thread] WARNING: ContentParent: id=2b74d46a400 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3709
[task 2022-06-18T15:15:56.002Z] 15:15:56     INFO - Browser exited with return code 0
[task 2022-06-18T15:15:56.007Z] 15:15:56     INFO - Closing logging queue
[task 2022-06-18T15:15:56.007Z] 15:15:56     INFO - queue closed
[task 2022-06-18T15:15:56.334Z] 15:15:56     INFO - Application command: Z:\task_165555813529169\build\application\firefox\firefox.exe -marionette about:blank --wait-for-browser -profile C:\Users\task_165555813529169\AppData\Local\Temp\tmp_z01hwd3
[task 2022-06-18T15:15:56.354Z] 15:15:56     INFO - PID 4264 | 1655564651233	Marionette	INFO	Marionette enabled
[task 2022-06-18T15:15:56.355Z] 15:15:56     INFO - PID 4264 | 1655564651236	Marionette	INFO	Listening on port 52260
[task 2022-06-18T15:15:56.356Z] 15:15:56     INFO - PID 4264 | JavaScript error: resource://gre/modules/XULStore.jsm, line 68: Error: Can't find profile directory.
[task 2022-06-18T15:15:56.357Z] 15:15:56     INFO - PID 4264 | console.warn: SearchSettings: "get: No settings file exists, new profile?" (new NotFoundError("Could not open the file at C:\\Users\\task_165555813529169\\AppData\\Local\\Temp\\tmpr96kce3i\\search.json.mozlz4", (void 0)))
[task 2022-06-18T15:15:56.358Z] 15:15:56     INFO - PID 4264 | 1655565161310	addons.xpi	ERROR	System addon update list error Error: Failed downloading XML, status: 0, reason: error
[task 2022-06-18T15:15:56.358Z] 15:15:56     INFO - Starting runner
[task 2022-06-18T15:15:57.283Z] 15:15:57     INFO - TEST-START | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-2.html

Comment 2

[Intermittent Failures Robot]

1 failures in 3170 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• windows10-64-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1774933&startday=2022-06-13&endday=2022-06-19&tree=all

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 4

[Treeherder Bug Filer]

New failure instance: https://treeherder.mozilla.org/logviewer?job_id=391239580&repo=mozilla-central

Comment 5

[Cristian Tuns]

This is a perma failures starting with this merge: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&searchStr=windows%2C10%2Cx64%2C2004%2Cccov%2Cwebrender%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows10-64-2004-ccov-qr%2Fopt-web-platform-tests%2Cwpt6&revision=4ce68ee50da2e00a53f4d9c5cc8d7e95426fd3cb&selectedTaskRun=RMai5K1sTjKV0N50owiYhw.0
Whimboo can you please take a look at this? I was thinking about Bug 1792021, but not rly sure about it.
Thanks!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When the test was still working the following is visible in the logs:

[task 2022-09-22T19:05:50.247Z] 19:05:50     INFO - TEST-START | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html
[task 2022-09-22T19:05:50.252Z] 19:05:50     INFO - Closing window 5a93eaae-9e65-40ef-b46e-591cc8c6f6c4
[task 2022-09-22T19:05:52.504Z] 19:05:52     INFO - PID 1736 | JavaScript error: http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d2), line 1: SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-09-22T19:05:53.496Z] 19:05:53     INFO - ..
[task 2022-09-22T19:05:53.496Z] 19:05:53     INFO - TEST-OK | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html | took 3255ms

When the test fails the following can be seen:

[task 2022-09-23T08:00:22.491Z] 08:00:22     INFO - TEST-START | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html
[task 2022-09-23T08:00:22.493Z] 08:00:22     INFO - Closing window 1fbd9ab3-5451-4ff8-ac75-a7ca0f69ac89
[task 2022-09-23T08:00:24.648Z] 08:00:24     INFO - PID 8988 | JavaScript error: http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d2), line 1: SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-09-23T08:00:25.606Z] 08:00:25     INFO - PID 8988 | JavaScript error: http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d3), line 1: SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-09-23T08:00:25.616Z] 08:00:25     INFO - TEST-UNEXPECTED-ERROR | /html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html | SyntaxError: Document.querySelector: ':::not-going-to-be-valid' is not a valid selector
[task 2022-09-23T08:00:25.621Z] 08:00:25     INFO - @http://web-platform.test:8000/html/semantics/scripting-1/the-script-element/resources/throw.js?pipe=trickle(d3):1:10
[task 2022-09-23T08:00:25.621Z] 08:00:25     INFO - TEST-INFO took 3135ms

As it can be seen there is a throw.js?pipe=trickle(d3) extra load which wasn't present before. Maybe this is related here?

https://searchfox.org/mozilla-central/source/testing/web-platform/tests/html/semantics/scripting-1/the-script-element/moving-between-documents/ordering/delay-load-event-1.html

So I'm not sure why it should come from my change for a global wpt test timeout for ccov builds.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Maybe the dots in the logs are hiding all these output in the passing tests.

I pushed two builds to try, one with my patch still in-tree and one more with the patch backed out:

with patch: https://treeherder.mozilla.org/jobs?repo=try&revision=2e25eea210dd96c4b31c2d7f7fbfa7f01c468928
without patch: https://treeherder.mozilla.org/jobs?repo=try&revision=030ad9cf55d047b7c1a0b15b6f028a567a280d5b

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The two try builds indeed show that it is a regression from my patch. To get more details what's going on I enabled the Marionette trace logs. Maybe those are helpful.

https://treeherder.mozilla.org/jobs?repo=try&revision=d26ab4f78f4a44ae5804a4e3403c97edd320ddd7

Henri, do you maybe have an idea why a longer timeout for ccov builds could cause such a failure? The test didn't even timeout before.

Comment 9

[Julian Descottes [:jdescottes]]

There is something really odd here. All the tests seem to take 25 seconds to run after your patch:

• move-back-iframe-parse-error-external-classic.html | took 24264ms
• move-back-iframe-parse-error-external-module.html | took 24294ms
• move-back-iframe-parse-error-inline-classic.html | took 24258ms
• ...

Whereas before your patch, they would only take 12 seconds:

• move-back-iframe-fetch-error-external-classic.html | took 12314ms
• ...

Those tests don't seem to timeout, but they still take as much time as possible. Which makes the whole suite much longer. Maybe we are hitting some kind of global timeout because of this?

Edit: Those tests seem to heavily rely on the "step_timeout" helper which is impacted by the timeout_multiplier we modified in the regressing bug.

Comment 10

[Julian Descottes [:jdescottes]]

Beyond the fact that those tests take a lot more time, I think the failing test is simply not compatible with a timeout_multiplier greater than 3...

The test page loads a script which will throw, but with 3 seconds of delay:

<script id="to-be-moved" src="../../resources/throw.js?pipe=trickle(d3)"></script>

Then the test script does:

  t.step_timeout(() => {
    const script = document.querySelector('#to-be-moved');
    iframe.contentDocument.body.appendChild(script);
  }, 1000);

So I imagine the condition for this to pass without getting the script's error is that the script tag needs to be moved BEFORE it is loaded. Meaning that step_timeout(..., 1000) must resolve before trickle(d3), which is no longer the case with a x4 multiplier.

We could increase the trickle delay maybe?

Comment 11

[Julian Descottes [:jdescottes]]

Although I actually imagine the trickle functions also follow the overall timeout... so there must be some other timing/delay which does not respect the multiplier, but I can't see it for now. FWIW, the test fails locally for me with or without the regressing patch.

Edit: I realize that I was confused about the fact that the timeout_multiplier actually applied to various delays used across tests, sorry for the spam and confusing comments. Based on the name, I thought this would only impact test timeouts, not overall timings. But even after looking more at it, I think the analysis from comment #10 is correct. The trickle delay does not seem affected by the timeout_multiplier, and the test will fail if the script is not moved before the load happens. We should maybe assert that the move happened, which would make for a clearer failure. But the test is essentially flawed because it relies on race conditions between various timeouts/delays, and only some of them follow apply the timeout_multiplier.

Comment 12

[Intermittent Failures Robot]

19 failures in 2909 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 19

Platform and build breakdown:

• windows10-64-2004-ccov-qr: 19
  • opt: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1774933&startday=2022-09-19&endday=2022-09-25&tree=all

Comment 13

[Julian Descottes [:jdescottes]]

To summarize:

1. step_timeout uses the timeout multiplier. With a timeout_multiplier of 4, a step_timeout scheduled with a 1000ms delay will actually run after 4000ms.
2. The trickle helper from wpt server does not use the timeout multiplier. trickle(d3) will block the load for 3 seconds, regardless of the timeout_multiplier's value.
3. Finally, the test delay-load-event-1.html assumes that a specific step_timeout will run before a throw.js script is loaded. The throw.js script's load is delayed using trickle(d3), so on platforms with timeout_multiplier set to 4, the step_timeout will actually run after the script's load, making the test invalid.

We could update the expectation for CCOV, or increase the trickle delay, but we might just backout Bug 1792021 for now. It was not clear to us that updating the timeout_multplier would impact internal helpers such as step_timeout.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

James, can you please have a look at Julian's comment? What would you propose to get this fixed? Should we backout bug 1792021 for now to find a proper solution for that above issue for it's re-landing?

Comment 15

[James Graham [:jgraham]]

Yeah, this is unfortunate. We don't propogate the timeout multiplier to the server, so things like trickle don't know about it. That sounds wrong, and is obviously wrong in this case, but it can also be what you want if you're trying to allow for a slower browser (e.g. if you had the opposite situation to these tests, and wanted to check that something happened after a network request you wouldn't want to slow down the request).

Anyway, I think these tests are broken, but it's somewhat difficult to fix them without having a way to pass the timeout multiplier into the delay. Which we don't have at the moment. We should file an upsream issue on that.

In the meantime, given that it's "only" ccov builds that are affected, we could disable or mark these tests as ERROR in that configuration. Or we can backout the timeout multiplier patch if we think that's also helping fix some other issues.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The patch on bug 1792021 has been backed out:
https://hg.mozilla.org/integration/autoland/rev/6b15a563499a5350d4dc7407eb6163c3f390aaa4

Any other work and the overall discussion to get it fixed will be handled there and on the web-platform-tests repository.

Comment 17

[Intermittent Failures Robot]

3 failures in 2041 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3

Platform and build breakdown:

• windows10-64-2004-ccov-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1774933&startday=2022-09-26&endday=2022-10-02&tree=all