1775013 - lazy.fetch is undefined in LoginRecipes.jsm

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Mark Banner (:standard8)]

Whilst working on adding a ESLint rule to check that uses of lazy.* are valid, I noticed that there's a lazy.fetch() call that is undefined. This was missed in bug 1608282.

I'm going to handle this here, since the ESLint rule is maybe still a couple of days away.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1775013 - Fix fetch being incorrectly called from a lazy property in LoginRecipes.jsm. r?sgalich

Comment 2

[Mark Banner (:standard8)]

Attachment: WIP: Bug 1775013 - Fix/ignore some duplicate imports caught by the new valid-lazy rule.

Depends on D149714

Comment 3

[Mark Banner (:standard8)]

Attachment: WIP: Bug 1775013 - Rework FormAutoFill's log creation to make it easier for linters to handle.

Depends on D149715

Comment 4

[Mark Banner (:standard8)]

Attachment: WIP: Bug 1775013 - Make XPIDatabase lazy getters easier to work with ESLint.

Depends on D149716

Comment 5

[Mark Banner (:standard8)]

Attachment: WIP: Bug 1775013 - Add ESLint rule to check for correct usages of lazy.

Depends on D149717

Comment 6

[Phabricator Automation]

Comment on attachment 9281969 [details]
WIP: Bug 1775013 - Fix/ignore some duplicate imports caught by the new valid-lazy rule.

Revision D149715 was moved to bug 1771173. Setting attachment 9281969 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9281970 [details]
WIP: Bug 1775013 - Rework FormAutoFill's log creation to make it easier for linters to handle.

Revision D149716 was moved to bug 1771173. Setting attachment 9281970 [details] to obsolete.

Comment 8

[Phabricator Automation]

Comment on attachment 9281971 [details]
WIP: Bug 1775013 - Make XPIDatabase lazy getters easier to work with ESLint.

Revision D149717 was moved to bug 1771173. Setting attachment 9281971 [details] to obsolete.

Comment 9

[Phabricator Automation]

Comment on attachment 9281972 [details]
WIP: Bug 1775013 - Add ESLint rule to check for correct usages of lazy.

Revision D149718 was moved to bug 1771173. Setting attachment 9281972 [details] to obsolete.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1608282

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb7b0cb4f4c8
Fix fetch being incorrectly called from a lazy property in LoginRecipes.jsm. r=sgalich

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/eb7b0cb4f4c8

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1608282