1775136 - Support `requireInteraction` and `actions` in alert service and Windows native notifications

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

Right now, Firefox does not support requireInteraction from the Web Notifications API: see Bug 1417846 for DOM exposure, Bug 1417848 for Web Extension exposure, etc. This ticket is more narrow: I would like to be able to specify requireInteraction to the Alert service in some form for use in Bug 1775128; it might just be a chrome-only option.

This is conceptually similar to Bug 1771164.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1775136 - Part 2: Support `requireInteraction` and `actions` in alert service and native Windows notifications. r?mhowell!,nrishel!,smaug!

1. requireInteraction already existed, but it doesn't do anything.
   This patch makes it mean scenario="reminder" in the Windows Toast
   notification schema: see
   https://docs.microsoft.com/en-us/uwp/schemas/tiles/toastschema/element-toast.

2. actions is intended to eventually support the Chrome-only
   extension to the Web Notifications API: see
   https://developer.mozilla.org/en-US/docs/Web/API/Notification/actions.

3. We run into an xpconnect limit on the number of supported
   parameters. Rather than bump the limit, which has global consequence,
   I added a second init* method. The existing abstraction is
   horrible, but I can't rework it within my timelines. Should we choose
   to invest, we might migrate to WebIDL so that we can sensibly use
   options objects.

4. I intend to follow with a commit that adds
   nsIWindowsAlertService, exposing both the produced XML for testing
   but also some Windows-specific options like changing the toast
   template and making any provided image be a hero image.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1775136 - Part 1: Add `nsIWindowsAlertService` to enable testing. r?mhowell

This also provides an entry point for Windows-specific styling of
alerts, should specific consumers want one: e.g.,
nsIWindowsAlertsService.showWindowsAlert(...) allowing to configure
the toast template, for example.

Comment 3

[Nick Alexander :nalexander [he/him]]

smaug: are you the right person to review this (alert service/notifications stuff)? Please suggest somebody else if not.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e75e93d9ba3
Part 1: Add `nsIWindowsAlertService` to enable testing. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/bfa523daaf13
Part 2: Support `requireInteraction` and `actions` in alert service and native Windows notifications. r=mhowell,smaug

Comment 5

[Atila Butkovits]

Backed out for causing failures at test_windows_alert_service.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/9b2daeb21efd0b94f47e3746fe87a2d5f4c84647

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=TL43dXlTRoW9WYV0b1AEVA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=bfa523daaf1315c897ae155c77dccc276b9416e1

Failure log: https://treeherder.mozilla.org/logviewer?job_id=384041611&repo=autoland&lineNumber=3647

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0e9183224fb
Part 1: Add `nsIWindowsAlertService` to enable testing. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/e3c0f3ee6bd1
Part 2: Support `requireInteraction` and `actions` in alert service and native Windows notifications. r=mhowell,smaug

Comment 7

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/c0e9183224fb
https://hg.mozilla.org/mozilla-central/rev/e3c0f3ee6bd1

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

(I was on vacation last week, so the review too a bit time ;) )