1775163 - bookmark_validator.js appears to be unused in production code

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Banner (:standard8)]

It looks like the last production use of bookmark_validator.js was removed in bug 1449730.

Although it is still referenced in services/sync/modules/engines/bookmarks.js, it isn't actually used there.

It is still referenced in a few places, including the tps extension and in tests.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

I'd be fine with moving this into TPS, so we could grab it back out for more general use if we wanted it later. Not sure what to do with the test though - maybe just adding a comment in the validator itself with a reference to a commit before the test is actually removed would be ok, so it too could be resurrected if needed.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1775163 - Move bookmarks_validator.js out of production code as it is no longer required there. r?markh

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/802e5ef4670f
Move bookmarks_validator.js out of production code as it is no longer required there. r=markh

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/802e5ef4670f