1449730 - Remove the non-mirror bookmarks engine

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P3)

Description

[Lina Butler [:lina]]

Once the mirror is on and working for everyone, we can remove the original engine, the pref, any custom TPS configs, some `PlacesSyncUtils` helpers and tests, and fold `BaseBookmarksEngine` back into `BufferedBookmarksEngine`.

Comment 1

[Manish [:manishkk]]

what exactly I need to do in this bug

Comment 2

[Manish [:manishkk]]

sorry! seems this one also depends on #1433177

Comment 3

[Lina Butler [:lina]]

Yup. It'll be a few months, sorry. :-) If you're looking for a good first Sync bug, check out bug 1383488 or bug 1375220, or bug 1406475 if you'd like something a bit more involved.

Comment 4

[Manish [:manishkk]]

Thanks, Kit.

I am working on some other bug, will try to finish ASAP but in future want to work on bugs related SYNC only. and I already with you on my first contribution. 
https://bugzilla.mozilla.org/show_bug.cgi?id=1408108

Comment 5

[Mark Banner (:standard8)]

Lina tells me that we should be able to do this now.

Comment 6

[Marco Bonardo [:mak]]

Mark, do you know the current status here?

Comment 7

[Lina Butler [:lina]]

Whew, sorry this got buried again! We've been shipping the new engine by default since 71, and haven't done any more work on the old engine, so we can do this now. Untangling the Sync tests is going to be the biggest challenge, though.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

What Lina said! :) Mak, for our interest, why do you ask? If this is blocking something we'd be happy to try and get it bumped in priority.

Comment 9

[Marco Bonardo [:mak]]

No, we're not blocked, thanks for asking!
I'm asking periodically just to understand where we are, because sometimes I end up speaking with Standard8 about remaining work to remove the synchronous APIs.
The only thing that is depending on this atm is the removal of nsIAnnotationService.idl and its implementation, if we could at least unblock that, without doing all the removal work, it would be nice.

Comment 10

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1449730 - remove the legacy bookmarks sync engine. r?lina

Depends on D88935

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb25371f5545
remove the legacy bookmarks sync engine. r=lina

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bb25371f5545

Comment 13

[Marco Bonardo [:mak]]

\O/