1775200 - Avoid updating CodeMirror unless it is strictly necessary

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

A few components are updating CodeMirror very frequently, that, even if the state/props didn't change.

This is especially the case for Editor/index.js:
https://searchfox.org/mozilla-central/rev/b1a5802e0f73bfd6d2096e5fefc2b47831a50b2d/devtools/client/debugger/src/components/Editor/index.js#155-173
Which calls startOperation/endOperation even if none of the sub function change anything.
Also setText will update CodeMirror, even if the state/props didn't change.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1775200 - [devtools] Avoid updating CodeMirror unless it is strictly necessary.

There is many props that are only relevant to the children components,
and we were calling expensive CodeMirror method on any prop change.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c1bb0a12baa
[devtools] Avoid updating CodeMirror unless it is strictly necessary. r=bomsy

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5c1bb0a12baa