1775334 - The subtitle settings panel remains displayed even when buttons get hidden (full screen PiP)

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user plays a video, launches the PiP and double-clicks to go full screen, opens the subtitle settings pannel to modify the settings and leaves cursor somewhere above the panel, he will notice that the PiP buttons will get hidden, but the subtitle settings pannel will remain on screen.

** Found in**

• Nightly v103.0a1

Affected versions

• Nightly v103.0a1

Affected platforms

• all

Steps to reproduce

1. Play a video:
   https://www.youtube.com/watch?v=4GGuRdotJGA
2. Launch PiP and go full screen.
3. Open the subtitle settings pannel.
4. Leave the cursor somewhere above the pannel and buttons.

Expected result

• The subtitle settings pannel gets hidden along with the PiP buttons.

Actual result

• The subtitle settings pannel remains displayed on the screen while the buttons get hidden after a few seconds.

Regression range

• not a regression.

Additional notes

• Only occurs on full screen; When not in full-screen PiP, the buttons will remain displayed until the user hovers outside of the PiP area, just like the panel.

Comment 1

[Ania]

We had a conversation with Niklas and Molly, and decided that if the subs settings panel is visible - > we do not hide the controls at all.

It seems like the most logical behavior, because the user is interacting with the controls, and removing all of them feels unwarranted.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1775334 - If subtitles settings is showing do not hide controls. r=#pip-reviewers!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox103 (beta). However, the bug still has low severity.

:yshash, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6d8948519b1
If subtitles settings is showing do not hide controls. r=pip-reviewers,mhowell

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b6d8948519b1

Comment 6

[Donal Meehan [:dmeehan]]

Please add a beta uplift request to get this into 103

Comment 7

[Daniel Bodea [:danibodea]]

This fix has changed the way the panel behaves:

• Before the fix:

• the buttons would disappear while the panel remained displayed
• clicking any button on the panel would leave it opened afterward

• After the fix:

• if the panel is left open, nor the buttons, neither the panel would disappear automatically
• clicking any button on the panel would also close the panel (with an exception: clicking the center of the radio button won't close the panel)

In comment 1 I can see the decision made to not close the panel automatically.
Is the other change intended also (automatically closing the panel when clicking an option)?

Comment 8

[Niklas Baumgardner [:niklas]]

Comment on attachment 9283065 [details]
Bug 1775334 - If subtitles settings is showing do not hide controls. r=#pip-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: The subtitles settings panel can show while the PiP controls buttons have disappeared. This patch fixes the issue and we want this to be fixed for the release of 103.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Go to any video with subtitles and open a PiP window

2. Open the subtitles settings panel by clicking the subtitles settings panel
3. Move the mouse to the middle of the PiP window and wait 10 seconds
   Result: the subtitles panel and the buttons should stay visible
4. With the panel still visible, move the mouse off the PiP window
   Result: the subtitles panel and the buttons should stay visible

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because this only changes behavior in a PiP window. This only changes UX behavior of when to hide the subtitles settings panel in the PiP window.
• String changes made/needed: No
• Is Android affected?: No

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9283065 [details]
Bug 1775334 - If subtitles settings is showing do not hide controls. r=#pip-reviewers!

Approved for 103.0b5, thanks.

Comment 10

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/aa2bddb42e77

Comment 11

[Ania]

Niklas, I might be blanking on this - I don't remember that we discussed closing the panel after the font size selection click, can you please remind me if that's what we settled on?

I would consider this an acceptable behavior for 103 and open a separate task to not close the settings panel upon the selection (as it creates a need for an additional click).

Comment 12

[Daniel Bodea [:danibodea]]

While observing the steps to reproduce written in the uplift request, I can safely assume that the only intended change was to leave the panel open even if the cursor is left hovering over the PiP for more than 10 seconds OR if the cursor would leave PiP area.

This being known, I can verify this fix in Nightly v104.0a1 on Windows 10, Mac OS 11, Ubuntu 22 (wayland).

I am still unsure what the intended behavior is regarding the panel closing when clicking an option.
If it is intended to close, then a bug about it not closing when clicking the center of the radio button (S3).
If it is not intended to close upon option selection, then it should be logged as an issue (S2).

I will assume was not intended to close it automatically, based on Ania's comment 11 and log another issue for that behavior (bug 1778295). I can however be made invalid if that is the case.

Comment 13

[Peter Magyari (Desktop QA)]

Verified fixed using Firefox Beta 103.0b5 (20220705185846) on MacOS 11, Windows 10 and Ubuntu 22.04.