1778295 - The PiP's subtitle settings panel closes upon clicking any option

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user plays a video, launches the PiP, opens the subtitle settings panel and clicks any option (subs toggle, or 1/3 subtitle font sizes), the panel closes instantly.

** Found in**

• Nightly v104.0a1

Affected versions

• Nightly v104.0a1
• Beta v103.0b5

Affected platforms

• all

Steps to reproduce

1. Play a video:
   https://www.youtube.com/watch?v=4GGuRdotJGA
2. Launch PiP and go full screen.
3. Open the subtitle settings panel.
4. Leave the cursor somewhere above the panel and buttons.

Expected result

• The subtitle settings panel gets hidden along with the PiP buttons.

Actual result

• The subtitle settings panel remains displayed on the screen while the buttons get hidden after a few seconds.

Regression range

• IF THIS CHANGE IS NOT INTENDED, then it's a regression that surfaced with the fix in bug 1775334.

Additional notes

• This issue does not occur if the user clicks the center of the radio buttons (of the font size selections).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1775334

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:niklas, since you are the author of the regressor, bug 1775334, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Daniel Bodea [:danibodea]]

A satisfactory workaround exists (reopening the panel) so I will lower the severity to S3.

Comment 4

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1778295 - Keep subtitles panel open when clicking button within. r=#pip-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c24bc961e35
Keep subtitles panel open when clicking button within. r=pip-reviewers,mhowell

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1c24bc961e35

Comment 7

[Niklas Baumgardner [:niklas]]

Comment on attachment 9284344 [details]
Bug 1778295 - Keep subtitles panel open when clicking button within. r=#pip-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Currently when the user clicks on a font size in the PiP subtitles settings panel, the panel will close. This patch will keep the panel open when selecting a font size and will also close when play/pause and mute/unmute are clicked, which is the desired behavior. We want this to go live in the 103 release.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR:

1. Navigate to https://www.youtube.com/watch?v=XdKzUbAiswE and open a PiP window with subtitles
2. Open the subtitles settings panel and select all the font sizes and toggle the subtitles on and off.
   Result: Confirm that the panel did not hide on any of these clicks.
3. Now with the panel open, click the play/pause button
   Result: the panel should hide
4. Now with the panel open again, click the mute/unmute button
   Result: the panel should hide

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because we are only changing when to hide the subtitles settings panel
• String changes made/needed: No
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9284344 [details]
Bug 1778295 - Keep subtitles panel open when clicking button within. r=#pip-reviewers

Approved for 103.0b6, thanks.

Comment 9

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a61947fcdc36

Comment 10

[Peter Magyari (Desktop QA)]

I've verified the fix using Nightly 104.0a1 (20220707214915) and Beta 103.0b6 (20220707185904) on Windows 10, MacOS 11 and Ubuntu 20.04.