Closed Bug 1775338 Opened 2 years ago Closed 2 years ago

Various improvements to reader mode color pallete to match Proton

Categories

(Toolkit :: Reader Mode, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

References

Details

Attachments

(1 file)

No description provided.

This includes:

  1. Convert most of the color used for light and dark themes to the ones we use for Proton. I haven't touched some grey colors as those are from Photon era and are still in use in most places in the Firefox UI. Also haven't touches the Sepia colors as we don't have a matching theme to copy the colors from.
  2. Make the font type buttons look as buttons in HCM.
  3. Change the highlight underline color in HCM to SelectedItem and lower it by a few pixels to not overlap with glyphs that descend below the baseline.
  4. When Sepia is selected, theme the popups accordingly.
  5. Invert the tooltip colors for dark mode as its dark background blends too well with the page's.
  6. Round the hover underline in popups.
  7. Fix button focusrings to not extend beyond their borders (also theme them accordingly).
  8. Fix an issue where scrolling a bit, opening a popup and clicking elsewhere that is not in the content area (say, devtools) would set the toolbar buttons to 0.6 opacity even though the popup is still open.
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Pushed by itiel_yn8@walla.com: https://hg.mozilla.org/integration/autoland/rev/dea01caaac46 Various improvements to reader mode r=Gijs,morgan
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Flags: qe-verify+
Regressions: 1800650
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: