1800650 - Reader Mode links have low contrast with Color Scheme Dark

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect)

Description

[Claas Augner [:claas]]

Steps to reproduce:

1. Open https://developer.mozilla.org/en-US/ in Firefox.
2. Toggle "Reader View".
3. Open "Type Controls" and switch to Color Scheme "Dark".
4. Notice that unvisited links have a low contrast.

Related:

• Originally fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1546213 (Fx 83).
• Regressed in https://bugzilla.mozilla.org/show_bug.cgi?id=1775338 (Fx 104).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:itiel_yn8, since you are the author of the regressor, bug 1775338, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Itiel]

Attachment: Bug 1800650 - Improve text/link selection coloring and use the primary color for links in dark mode, in Reader Mode r?morgan

Comment 3

[Jeff Fortin]

I don't seem to be able to edit the "See also" field, but please have a look at these other tickets if you hadn't seem them already, as far as I know this is a long-standing issue in the dark version of Reader mode, not just a recent regression? Bug #1546213, bug #1695199, bug #1654425

Or how did it get worse recently, vs the existing low-contrast dark-blue hyperlinks on dark backgrounds? Or are the bugs above all essentially duplicates?

In my view, Bugzilla's hyperlinks color scheme in the dark variant (that we can see here when the browser is in dark mode) is much better, in terms of color palette, than Reader mode's. Maybe the same kind of blue and pink could be used?

Comment 4

[Itiel]

(In reply to Jeff Fortin from comment #3)

I don't seem to be able to edit the "See also" field, but please have a look at these other tickets if you hadn't seem them already, as far as I know this is a long-standing issue in the dark version of Reader mode, not just a recent regression? Bug #1546213, bug #1695199, bug #1654425

Or how did it get worse recently, vs the existing low-contrast dark-blue hyperlinks on dark backgrounds? Or are the bugs above all essentially duplicates?

In my view, Bugzilla's hyperlinks color scheme in the dark variant (that we can see here when the browser is in dark mode) is much better, in terms of color palette, than Reader mode's. Maybe the same kind of blue and pink could be used?

In the patch above I'm making links look and feel the same as links in about:preferences.
Bugzilla's hyperlinks color scheme is different than Firefox's color palette, so even though it looks good, it shouldn't be forked over to Firefox.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9cb7c933798
Improve text/link selection coloring and use the primary color for links in dark mode, in Reader Mode r=morgan

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f9cb7c933798

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:itiel_yn8, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2022-11-15 Nightly build on macOS 12.
Verified as fixed on Firefox 109.0b4(build ID: 20221218190303) and Nightly 110.0a1(build ID: 20221218193142) on macOS 12, Windows 10, Ubuntu 22.