Closed Bug 1776013 Opened 3 years ago Closed 3 years ago

String.prototype.includes should be SIMD-optimized

Categories

(Core :: JavaScript: Standard Library, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: alexical, Assigned: alexical)

References

Details

Attachments

(2 files)

Setting up this bug to track existing work regarding making String.prototype.includes and String.prototype.indexOf's faster through SIMDification.

Attachment #9282495 - Attachment description: Bug 1776013 - Consume mdbt SIMD for String builtins r?iain → Bug 1776013 - Consume mfbt SIMD for String builtins r?iain
Severity: -- → S3
Priority: -- → P1
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9669cd465518 Add SIMD memchr-like implementations to MFBT r=iain https://hg.mozilla.org/integration/autoland/rev/bb467568da37 Consume mfbt SIMD for String builtins r=iain

Backed out for causing spidermonkey bustages on SIMD.cpp

Backout link

Push with failures

Failure log

Flags: needinfo?(dothayer)
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05b8d4030ff8 Add SIMD memchr-like implementations to MFBT r=iain https://hg.mozilla.org/integration/autoland/rev/bcfc4b4d52b9 Consume mfbt SIMD for String builtins r=iain
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Flags: needinfo?(dothayer)
Blocks: 1779807

Did this cause these big improvements on Jetstream2 -AWFY?

https://arewefastyet.com/win10/benchmarks/raptor-desktop-jetstream2?numDays=60
regexp-Average
regexp-First
regexp-Geometric
regexp-Worst

(In reply to Mayank Bansal from comment #7)

Did this cause these big improvements on Jetstream2 -AWFY?

https://arewefastyet.com/win10/benchmarks/raptor-desktop-jetstream2?numDays=60
regexp-Average
regexp-First
regexp-Geometric
regexp-Worst

Just tested it locally and yes, this patch appears to be the cause. \o/

I'm also seeing a difference locally on regex-dna-SP., though I think it's more pronounced locally because I have the AVX2 stuff from bug 1779807 applied (which I should be able to land today.)

Regressions: 1782141
Regressions: 1801690
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: