Closed Bug 1776221 Opened 2 years ago Closed 2 years ago

Changing theme outside of Firefox View should update Colorway CTA in Firefox View

Categories

(Firefox :: Theme, enhancement)

enhancement
Points:
3

Tracking

()

VERIFIED FIXED
104 Branch
Tracking Status
firefox104 --- verified
firefox105 --- verified

People

(Reporter: bigiri, Assigned: bigiri)

References

Details

(Whiteboard: [fidefe-2022-mr1-colorways] )

Attachments

(1 file)

Right now the Colorway CTA in Firefox View does not listen to theme change events. It needs to be enhanced to track those so that theme changes are captured and the Firefox View page is always consistent with the current theme selection.

With this fix changing the Colorway theme should automatically update the Colorway CTA in Firefox View. Additionally, firefoxview.js has been restructured to match the design patterns in colorwaycloset.js.

Assignee: nobody → bigiri
Status: NEW → ASSIGNED
Attachment #9283851 - Attachment description: Bug 1776221 - Added auto update of Colorway CTA one theme change r=Dao! → WIP: Bug 1776221 - Added auto update of Colorway CTA one theme change r=Dao!
Points: --- → 3
Attachment #9283851 - Attachment description: WIP: Bug 1776221 - Added auto update of Colorway CTA one theme change r=Dao! → WIP: Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao!
Attachment #9283851 - Attachment description: WIP: Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao! → Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao!
See Also: → 1779210
Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ad72b0c451f
Added auto update of Colorway CTA on theme change r=dao
Regressions: 1779440

Backed out for causing bc failures on browser_colorways_card.js

Backout link

Push with failures

Failure log

Flags: needinfo?(bigiri)
Flags: needinfo?(bigiri)
Attachment #9283851 - Attachment description: Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao! → Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao!,Sfoster!
Blocks: 1779210
Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f00843f296b
Added auto update of Colorway CTA on theme change r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Flags: qe-verify+

Verified the fix where the Colorway themes changes accordingly with Firefox 105.0a1 (2022-08-22) under macOS 13, Ubuntu 22.04 and Windows 11.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: