Closed
Bug 1776221
Opened 2 years ago
Closed 2 years ago
Changing theme outside of Firefox View should update Colorway CTA in Firefox View
Categories
(Firefox :: Theme, enhancement)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
104 Branch
People
(Reporter: bigiri, Assigned: bigiri)
References
Details
(Whiteboard: [fidefe-2022-mr1-colorways] )
Attachments
(1 file)
Right now the Colorway CTA in Firefox View does not listen to theme change events. It needs to be enhanced to track those so that theme changes are captured and the Firefox View page is always consistent with the current theme selection.
Updated•2 years ago
|
Updated•2 years ago
|
Blocks: colorway-closet
Assignee | ||
Comment 2•2 years ago
|
||
With this fix changing the Colorway theme should automatically update the Colorway CTA in Firefox View. Additionally, firefoxview.js has been restructured to match the design patterns in colorwaycloset.js.
Updated•2 years ago
|
Assignee: nobody → bigiri
Status: NEW → ASSIGNED
Updated•2 years ago
|
Attachment #9283851 -
Attachment description: Bug 1776221 - Added auto update of Colorway CTA one theme change r=Dao! → WIP: Bug 1776221 - Added auto update of Colorway CTA one theme change r=Dao!
Updated•2 years ago
|
Attachment #9283851 -
Attachment description: WIP: Bug 1776221 - Added auto update of Colorway CTA one theme change r=Dao! → WIP: Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao!
Updated•2 years ago
|
Attachment #9283851 -
Attachment description: WIP: Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao! → Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao!
Pushed by bigiri@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ad72b0c451f Added auto update of Colorway CTA on theme change r=dao
Comment 4•2 years ago
|
||
Backed out for causing bc failures on browser_colorways_card.js
Flags: needinfo?(bigiri)
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(bigiri)
Updated•2 years ago
|
Attachment #9283851 -
Attachment description: Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao! → Bug 1776221 - Added auto update of Colorway CTA on theme change r=Dao!,Sfoster!
Pushed by bigiri@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f00843f296b Added auto update of Colorway CTA on theme change r=sfoster
Comment 6•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox104:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Updated•2 years ago
|
Flags: qe-verify+
Comment 7•2 years ago
|
||
Verified the fix where the Colorway themes changes accordingly with Firefox 105.0a1 (2022-08-22) under macOS 13, Ubuntu 22.04 and Windows 11.
You need to log in
before you can comment on or make changes to this bug.
Description
•