Closed Bug 1743985 (colorway-closet) Opened 2 years ago Closed 1 year ago

[meta] [MR1 2022] Colorway Closet

Categories

(Firefox :: Theme, task, P1)

task

Tracking

()

RESOLVED FIXED
a11y-review passed

People

(Reporter: dao, Unassigned)

References

(Depends on 5 open bugs)

Details

(Keywords: meta)

This is a continuation of the previous Colorways project, aka monochromatic themes (bug 1725467). High-level goals of this project:

  • Make colorways and related content easily and conveniently accessible in Firefox
  • Invest in user incentives for opting into a default Firefox Home page experience
  • Continue to broaden and invest in an improved personalized user experience
  • Invest in long term support infrastructure of colorways

Spec: https://docs.google.com/document/d/1Ja5d3TGROj1Phmm3x3ns_vUM_b0x5v-u2pEEFobtLvY/edit#

Depends on: 1743986
Depends on: 1736218
Depends on: 1747229
See Also: → 1747248
Depends on: 1749583
Depends on: 1750788
Depends on: 1751183

Description:
Meta bug for testing the New Tab Personalize panel surface. Epic and storypoints can be referenced here: https://mozilla-hub.atlassian.net/browse/FIDE-643

How do we test this?
The user scenarios are outlined here:
https://mozilla-hub.atlassian.net/browse/FIDE-664

When will this ship?
Tracking bug/issue: Fx100
Design documents (e.g. Product Requirements Document, UI spec): https://www.figma.com/file/lyP8RzsPyprRSm2ue4VsWi/Colorway-Closet?node-id=210%3A1191
Engineering lead: Dao Gottwald
Product manager: Ray Fambro

The accessibility team has developed the Mozilla Accessibility Release Guidelines which outline what is needed to make user interfaces accessible:
https://wiki.mozilla.org/Accessibility/Guidelines
Please describe the accessibility guidelines you considered and what steps you've taken to address them:

Describe any areas of concern to which you want the accessibility team to give special attention:

a11y-review: --- → requested
Depends on: 1752341
Depends on: 1761310
Depends on: 1761313
No longer depends on: 1750788
No longer depends on: 1752341
Depends on: 1763430
Depends on: 1763432
Depends on: 1765794
Depends on: 1765798
Depends on: 1766293
Depends on: 1767010
Depends on: 1767017
Depends on: 1768518
Depends on: 1768470
Depends on: 1768744
Depends on: 1770030
Depends on: 1771227
Depends on: 1770046
Depends on: 1771775
Depends on: 1771961
Depends on: 1771988
Depends on: 1772364
Depends on: 1772534
Depends on: 1773644
Depends on: 1773651
Depends on: 1773800
Depends on: 1774068
Depends on: 1774432
Depends on: 1776546
Depends on: 1776548
Depends on: 1776712
Depends on: 1777536
Depends on: 1777531
Depends on: 1776682
Depends on: 1776221
Depends on: 1777772
Depends on: 1778118
Depends on: 1778134
Depends on: 1778280
Depends on: 1778362
Depends on: 1778468
Depends on: 1778483
Depends on: 1778556
Depends on: 1778664
Depends on: 1779017
Depends on: 1779210
Depends on: 1779282
Depends on: 1779546
Depends on: 1779547
No longer depends on: 1738322
See Also: → 1738322
Depends on: 1779589
Depends on: 1779714
No longer depends on: 1779714
a11y-review: requested → ---

Description:
Please provide an explanation of the feature or change. Include a description of the user scenario in which it would be used and how the user would complete the task(s).

  • We are now ready to move forward with the final a11y review for the colorways modal experience. Users will be able to enter the colorways modal via the Firefox View surface and the about:addons page. Surfacing the modal will allow users to set a base colorway with an intensity. Custom Homepage users can also set Firefox Home to their default homepage in this modal surface as well.

Screenshots and visual UI specs are welcome, but please include sufficient accompanying explanation so that blind members of the accessibility team are able to understand the feature/change.

  • Upon opening the modal, users can change the element of focus by selecting the tab key. For the colorway selector, users can also use the arrow keys to navigate each base color option

How do we test this?
If there is an implementation to test, please provide instructions for testing it; e.g. setting preferences, other preparation, how to trigger the UI, etc.

  • Please set the pref to "true" in about:config. (browser.theme.colorway-closet)
  • Note that this will provide an entrypoint for the colorways modal via about:addons
  • The primary colorways modal entrypoint is through the Firefox View UI. This review request is however for colorways only, as Firefox View is not yet ready for final testing. You can still turn this experience on if desired by enabling the pref (browser.tabs.firefoxview).
  • The colorway modal UI is triggered by selecting the "try colorways/change colorways" button in the about:addons page or in the Firefox View tab.

When will this ship?

  • This is ship in the Fx106 Release cycle

Tracking bug/issue:

  • 1743985

Design documents (e.g. Product Requirements Document, UI spec):

Engineering lead: Dao Gottwald
Product manager: Ray Fambro

The accessibility team has developed the Mozilla Accessibility Release Guidelines which outline what is needed to make user interfaces accessible:
https://wiki.mozilla.org/Accessibility/Guidelines
Please describe the accessibility guidelines you considered and what steps you've taken to address them:

  • We have already discussed and addressed contrast requirements. We would now like to test out functionality as we approach the ship release date.

Describe any areas of concern to which you want the accessibility team to give special attention:

a11y-review: --- → requested
Depends on: 1780270
Depends on: 1780272
Depends on: 1780274
Depends on: 1780266
Depends on: 1780406
Depends on: 1780525
Blocks: 1780542
No longer blocks: 1780542
Depends on: 1780542
Depends on: 1780568

I've looked over the implementation and it looks good to me. It would still be good to have QA do their accessibility tests as well.

a11y-review: requested → passed
Depends on: 1780835
Depends on: 1781073
Depends on: 1781755
Depends on: 1782065
Depends on: 1782291
Depends on: 1782531
Depends on: 1782168
Depends on: 1782695
Alias: colorway-closet
Depends on: 1783011
Depends on: 1783166
Depends on: 1783200
Depends on: 1783671
Depends on: 1783675
Depends on: 1783714
Depends on: 1783868
Depends on: 1783886
Depends on: 1783887
Depends on: 1784029
Depends on: 1784034
Depends on: 1784044
Depends on: 1784054
Depends on: 1784087
Depends on: 1784241
Depends on: 1784282
Depends on: 1784433
Depends on: 1784439
Depends on: 1784448
Depends on: 1784488
Depends on: 1785094
Depends on: 1785203
Depends on: 1785265
Depends on: 1785904
Depends on: 1786023
Depends on: 1785835
Depends on: 1785902
Depends on: 1786337
Depends on: 1786371
No longer depends on: 1786371
Depends on: 1786371
Depends on: 1786389
No longer depends on: 1786389
Depends on: 1786389
Depends on: 1786478
Depends on: 1786482
Depends on: 1786597
Depends on: 1786627
No longer depends on: 1786627
Depends on: 1786604
Depends on: 1787523
Depends on: 1786327
Depends on: 1787973
Depends on: 1788693
Depends on: 1788800
Depends on: 1789625
Depends on: 1789628
Blocks: 1789648
Depends on: 1788822
Depends on: 1788274
Depends on: 1789009
No longer depends on: 1789009
Depends on: 1789911
Depends on: 1790001
Depends on: 1790010
Depends on: 1790011
Depends on: 1790048
Depends on: 1790050
Depends on: 1791172
Depends on: 1792543
Depends on: 1794369
Depends on: 1796569
Depends on: 1796571
Depends on: 1798412
No longer depends on: 1789911
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.