1776222 - Double clicking an audio tag shouldn't set it to fullscreen

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Toad]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

1- Browse to: https://www.w3schools.com/html/tryit.asp?filename=tryhtml5_audio_all

2- Double-click the <audio> tag (on the "0:00 / 0:02" part).

Actual results:

• The <audio> tag went fullscreen (displaying nothing but a completely black screen).

• When exiting the fullscreen mode, the controls of the <audio> tag were no longer visible.

Expected results:

No fullscreen.

Comment 1

[Ina Popescu, Desktop QA]

I've managed to reproduce this issue on the latest versions Nightly 103.0a1 and Firefox 102.0 on Windows x64.
Setting this to NEW. If this is not the right component, please move it to a more appropriate one.

Narrowed down the regression window to:
Last good revision: 55b737b06eeb689d5b2f575678009f3f2b9e6967
First bad revision: a7ec72bd52ce8368523d30ca971b3d0009cec57e
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=55b737b06eeb689d5b2f575678009f3f2b9e6967&tochange=a7ec72bd52ce8368523d30ca971b3d0009cec57e

Comment 2

[BugBot [:suhaib / :marco]]

:ahochheiden, since you are the author of the regressor, bug 1754726, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Alex Hochheiden [:ahochheiden] [he/him]]

Ina, I think that it's not possible that my change in the Build System regarding capturing stderr output from tests ran with ./mach python-test caused this regression (or would impact Firefox in anyway). I think there may have been an error in your bisection. Could you please repeat the bisection and see if you come to a different result?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The parent commit (bug 1683053) regressed it.

Comment 6

[Bernard Igiri]

Attachment: Bug 1776222 - Disable fullscreen on audio tags r=jaws!

Disabling fullscreen on audio tags so that double clicking does not cause those tags to display as full screen.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e585877f991
Disable fullscreen on audio tags r=jaws

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3e585877f991

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:bigiri, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on Firefox 104.0(build ID: 20220818191623) on macOS 12 using the STR from the Description. Verified as fixed on Firefox 105.0b4(build ID: 20220828190315) and Nightly 106.0a1(build ID: 20220828210513) on macOS 12, Ubuntu 22.04, Windows 10.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Hi Bernard, I know we're still sorting through some test issues from this patch, but I'm thinking this is still probably a regression we want to fix on ESR102 before we start migrating users from ESR91 to it in a couple weeks. Please nominate this patch for ESR102 approval if you agree. It grafts cleanly.

Comment 13

[Bernard Igiri]

Comment on attachment 9286717 [details]
Bug 1776222 - Disable fullscreen on audio tags r=jaws!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Users are being migrated from ESR91 to ESR102 and they will benefit from this fix.
• User impact if declined: If users double click on an audio tag in the browser it will unexpectedly full-screen the audio player.
• Fix Landed on Version: 105
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): The fix involves adding a single if statement with only one condition. The fix has been verified manually, however the automated test has been disabled due to intermittent failures of the test. Finding a way to automate this test without intermittent failures, has been challenging.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9286717 [details]
Bug 1776222 - Disable fullscreen on audio tags r=jaws!

Approved for 102.3esr. I included the test disabling in this patch, but we can certainly re-enable on ESR also when there's a fix ready to go.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/d64e15c55783

Comment 16

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello,
I confirm this fix is verified on Firefox 102.3.0esr(build ID: 20220912135840) on macOS 12, Ubuntu 22.04 and Windows 10.