1776296 - Remove nsPrintJob's initialization code around mIsForModalWindow, per its reference to (closed) bug 1558907

Status: RESOLVED FIXED

(Core :: Printing: Output, task)

Description

[Daniel Holbert [:dholbert]]

I noticed this block of code in our nsPrintJob initialization code:

https://searchfox.org/mozilla-central/rev/45ecfdfaa2f74083b11c1414ddb4c1a640b0d19d/layout/printing/nsPrintJob.cpp#278-284

if (nsPIDOMWindowOuter* window = aOriginalDoc->GetWindow()) {
  if (nsCOMPtr<nsIWebBrowserChrome> wbc = window->GetWebBrowserChrome()) {
    // We only get this in order to skip opening the progress dialog when
    // the window is modal.  Once the platform code stops opening the
    // progress dialog (bug 1558907), we can get rid of this.
    wbc->IsWindowModal(&mIsForModalWindow);
  }

The comment there refers to bug 1558907, which is now WORKSFORME ("Obsoleted by bug 1745452" per bug 1558907 comment 5).

jwatt, should we take action on this^ code-comment and do some cleanup/simplification here?

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1776296 - Remove nsPrintJob::mIsForModalWindow. r=dholbert

Comment 2

[Jonathan Watt [:jwatt]]

Thanks, Daniel.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd492741a061
Remove nsPrintJob::mIsForModalWindow. r=dholbert

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cd492741a061