Closed Bug 1776449 Opened 3 years ago Closed 2 years ago

Windows warning: "NativeOSFileInternals.cpp(824,24): warning: result of comparison 'unsigned long long' > 18446744073709551615 is always false [-Wtautological-type-limit-compare]"

Categories

(Toolkit Graveyard :: OS.File, defect, P4)

Product:
Toolkit Graveyard
Component:
OS.File
Platform:
Unspecified
Windows
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: RyanVM, Unassigned)

References

Details

Looks like this was added in bug 1607816.

toolkit/components/osfile/NativeOSFileInternals.cpp(824,24): warning: result of comparison 'unsigned long long' > 18446744073709551615 is always false [-Wtautological-type-limit-compare]
        needed.value() > std::numeric_limits<nsAString::size_type>::max()) {
        ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This really regressed when nsAString::size_type was changed to size_t rather than uint32_t.

Depends on: 1776480

The severity field is not set for this bug.
:barret, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(brennie)
Severity: -- → S4
Flags: needinfo?(brennie)
Priority: -- → P4

OS.File is pending removal

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.