1776480 - Remove OS.File

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task, P3)

Comment 1

[Beth Rennie [:beth] (she/her)]

This needs to remove toolkit/components/lz4/ and https://searchfox.org/mozilla-central/rev/75da1dd5d4b9b991f919a41594194eab93cdef62/js/xpconnect/tests/browser/browser_import_mapped_jsm.js#31

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1776480 - Remove OS.File et al. r?gijs

This patch removes the vast majority of OS.File and support code. A few things remain:

• The nsIOSFileConstantsService still exists, but the path related constants
  (OS.Constants.Path.*) are no longer added to the OS object. The plan is to
  replace this with a proper service e.g. Services.osConstants or similar) in
  bug 1786885.
• There is still support for OS.File errors in ErrorSanitizer, which will be
  removed in bug 1775167.
• The OS.File to IOUtils migration guide will be rewritten as general IOUtils
  documentation in bug 1830097.
• dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
  which may want to be reconsidered in bug 1830100.

So long, and thanks for all the I/O.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc8a2b80e9f6
Remove OS.File et al. r=Gijs

Comment 5

[Atila Butkovits]

Backed out for causing Gecko Decision bustage.

Backout link: https://hg.mozilla.org/integration/autoland/rev/eb0bb293423e69ba6080f339a38001cf63278e1d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=fc8a2b80e9f680aed4f159ff3079f8a4f64761c9

Failure log: https://treeherder.mozilla.org/logviewer?job_id=414067727&repo=autoland&lineNumber=1996

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d766d94945d
Remove OS.File et al. r=Gijs

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing multiple xpcshell and bc failures

Backout link

Push with failures 1 - xpcshell -> Failure log 1 - xpcshell
Push with failures 2 - xpcshell -> Failure log 2 - xpcshell
Push with failures 3 - bc -> Failure log 3 - bc
Push with failures 4 - bc -> Failure log 4 - bc

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/987d013caf11
Remove OS.File et al. r=Gijs,webidl,smaug

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures in toolkit/components/extensions/test/xpcshell/test_ext_downloads_download.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/cac4f52c354ca171123bf562a2314ee171fe73e2

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_downloads_download.js | xpcshell return code: 0

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c698636dbfea
Remove OS.File et al. r=Gijs,webidl,smaug

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c698636dbfea