Closed
Bug 1776578
Opened 2 years ago
Closed 2 years ago
Make no-addtask-setup also check for init()
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox107 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: mathew.hodson, Assigned: mathew.hodson)
References
(Regressed 1 open bug)
Details
Attachments
(2 files)
|
Assignee | |
Updated•2 years ago
|
Component: Mochitest → Lint and Formatting
Depends on: 1753696
Product: Testing → Firefox Build System
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → mathew.hodson
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
||
Comment 3•2 years ago
|
||
Comment on attachment 9282943 [details]
Bug 1776578 - Replace init tasks with add_setup in mochitests. r?Gijs
Revision D149486 was moved to bug 1761576. Setting attachment 9282943 [details] to obsolete.
Attachment #9282943 -
Attachment is obsolete: true
|
|
||
Updated•2 years ago
|
Attachment #9282943 -
Attachment description: WIP: Bug 1776578 - Replace init tasks with add_setup in tests. r?Gijs → WIP: Bug 1776578 - Replace init tasks with add_setup in tests.
Attachment #9282943 -
Attachment is obsolete: false
|
|
||
Updated•2 years ago
|
Attachment #9282942 -
Attachment description: Bug 1776578 - Make no-addtask-setup eslint rule check for init tasks. r?Gijs → WIP: Bug 1776578 - Make no-addtask-setup eslint rule check for init tasks.
|
|
||
Updated•2 years ago
|
Attachment #9282943 -
Attachment description: WIP: Bug 1776578 - Replace init tasks with add_setup in tests. → Bug 1776578 - Replace init tasks with add_setup in tests. r?Gijs
|
|
||
Updated•2 years ago
|
Attachment #9282942 -
Attachment description: WIP: Bug 1776578 - Make no-addtask-setup eslint rule check for init tasks. → Bug 1776578 - Make no-addtask-setup eslint rule check for init tasks. r?Gijs
| Comment hidden (off-topic) |
|
||
Comment 5•2 years ago
|
||
Sorry, there was a problem with the detection of inactive users. I'm reverting the change.
Assignee: nobody → mathew.hodson
Status: NEW → ASSIGNED
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
|
|
||
Updated•2 years ago
|
Attachment #9282943 -
Attachment description: Bug 1776578 - Replace init tasks with add_setup in tests. r?Gijs → Bug 1776578 - Replace init tasks with add_setup in mochitests. r?Gijs
|
|
Assignee | |
Comment 6•2 years ago
|
||
Can you look at this patch again? I limited the changes to files that were previously covered by the lint. Other failures I saw on try looked like preexisting intermittent failures.
Flags: needinfo?(standard8)
|
||
Updated•2 years ago
|
Flags: needinfo?(standard8)
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a039f80f572 Replace init tasks with add_setup in mochitests. r=application-update-reviewers,Standard8 https://hg.mozilla.org/integration/autoland/rev/43369097d907 Make no-addtask-setup eslint rule check for init tasks. r=mossop
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4a039f80f572
https://hg.mozilla.org/mozilla-central/rev/43369097d907
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox107:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•