1776615 - [macOS] Theming issues with system dark mode

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: macos-issues.png

Opening this from a user reporting the issue on the UX mailing list:

"Hello

I tried Thunderbird 102RC1 on macOS 10.13.6 (so without system native dark theme) and noticed the following issues with the dark theme (compared to TB 91.10) :

1-The toolbar of the composer is almost white

2-The main password window and pop-ups are white

3-The color of the icons and labels while receiving new email do not match and is almost not readable on TB102 RC1"

Comment 1

[Richard Marti (:Paenglab)]

I have no macOS 10.13 but on 12 all looks okay with TB 102.RC1.
I also found no OS version switch that should affect this issues.

Comment 2

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB 102 RC1-macOS10.13-Theme Issues-NewProfileFromScratch.jpeg

I tried again, from a new profile created from scratch
I have this result, with the TB dark theme enable.
The issue about the mail box label while receiving new mail is gone (issue from my previous old profile ?).

Comment 3

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB 102 RC1-macOS11-Theme Issues-NewProfileFromScratch.jpeg

I tried the same on macOS 11 (White system theme + Dark TB Theme, TB new profile from scratch) and there are no issues.

Comment 4

[Nicolas Mandil (:NicolasWeb)]

I tried to disable the HW-acceleration on macOS 10.13, and still have the issues.
Tell me if I can do something to help finding the bug ? ;) (here or by email np)

Comment 5

[Richard Marti (:Paenglab)]

Attachment: userChrome.css

Nicolas, could you try to apply this userChrome.css? If all goes well, the format toolbar in composer should have the correct background colour and the dialogs and the menulists in filter editor have a red background.

When you don't know where to place the userChrome.css, this link hopefully helps: https://www.howtogeek.com/334716/how-to-customize-firefoxs-user-interface-with-userchrome.css/

Important is also that toolkit.legacyUserProfileCustomizations.stylesheets is set to true in the advanced Preferences (Settings > General on bottom the Config Editor button).

Comment 6

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB - Red Test.jpeg

Richard,
I tried it, and yes it became as you said.
What’s next ? ;)

Comment 7

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB - NPFS2 - Filters.jpeg

BTW,
I noticed that the filters window high were becoming smaller and smaller (with UserChrome or not).
Could it be related ? Profile file corruption ?
Should I open a new bug for that ?

So I made again a totally new profile from scratch and the filters window high were becoming smaller and smaller still

Steps to reproduce :

1. Delete your profile folder content
2. Configure a new profile with TB wizard
3. Open menu Tools > Filters
4. Click New, then Cancel or Hit Key Escape
5. Repeat that last step

Comment 8

[Richard Marti (:Paenglab)]

(In reply to Nicolas Mandil (:NicolasWeb) from comment #6)

I tried it, and yes it became as you said.
Many thanks for the testing. It shows me where I can fix the issues.
What’s next ? ;)
I'll make a patch to fix the issues that can hopefully land in 102.0.2. :-)

Comment 9

[Richard Marti (:Paenglab)]

Oh, I forgot: until the fix lands you could try to change the red in the file to a #1c1d22. Then it should look already almost like the end product.

Comment 10

[Nicolas Mandil (:NicolasWeb)]

(In reply to Richard Marti (:Paenglab) from comment #8)

I'll make a patch to fix the issues that can hopefully land in 102.0.2. :-)

Thanks ! Will your patch address the issue of comment #7 too ?
Or should I open a new bug for that ?

(In reply to Richard Marti (:Paenglab) from comment #9)

Oh, I forgot: until the fix lands you could try to change the red in the file to a #1c1d22. Then it should look already almost like the end product.

:))

Comment 11

[Richard Marti (:Paenglab)]

Please file a separate bug.

Comment 12

[Richard Marti (:Paenglab)]

Attachment: Bug 1776615 - Fix the theming for older macOS versions. r=aleca

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bcda942b2159
Fix the theming for older macOS versions. r=aleca

Comment 14

[Richard Marti (:Paenglab)]

Comment on attachment 9283827 [details]
Bug 1776615 - Fix the theming for older macOS versions. r=aleca

[Approval Request Comment]
User impact if declined: wrong colours on older macOS with TB dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9283827 [details]
Bug 1776615 - Fix the theming for older macOS versions. r=aleca

[Triage Comment]
Approved for beta

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 103.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/141f56bae55a

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9283827 [details]
Bug 1776615 - Fix the theming for older macOS versions. r=aleca

[Triage Comment]
Approved for esr102

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 102.0.2:
https://hg.mozilla.org/releases/comm-esr102/rev/6f9129ef10dd