1776876 - Make the use of `setTimeout` more clear in formautofill testcase

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P3)

Description

[Dimi Lee [:dimi]]

Some refactoring work we can do to make using setTimeout in formautofill testcase more explicit

• When a setTimeout is needed in the testcase, we can add a utility function (ex. ensureNoAutocompletePopup to make the usage more clear
• We don't use setTimeout in browser_first_time_use_doorhanger.js, so eslint-disable mozilla/no-arbitrary-setTimeout can be removed from browser_first_time_use_doorhanger.js

Comment 1

[Janika Neuberger (:janikaneuberger)]

Attachment: Bug 1776876 - Make the use of setTimeout clearer and relocate it to head.js

Comment 2

[Janika Neuberger (:janikaneuberger)]

The use of setTimeout in browser_editCreditCardDialog.js could be refactored but is a workaround for Bug 1700685 anyway. Refactoring might be unnecessary here?

// This test used to rely on the implied initial timer of
// TestUtils.waitForCondition. See bug 1700685.
// eslint-disable-next-line mozilla/no-arbitrary-setTimeout
          await new Promise(resolve => setTimeout(resolve, 10));

          await TestUtils.waitForCondition(
            () => labelEl.textContent,
            "Wait for label to be populated by the mutation observer",
            10
          );

Comment 3

[Dimi Lee [:dimi]]

(In reply to Janika Neuberger (:jneuberger) from comment #2)

The use of setTimeout in browser_editCreditCardDialog.js could be refactored but is a workaround for Bug 1700685 anyway. Refactoring might be unnecessary here?

I guess you mean browser_editAddressDialog.js? If yes, then yes, I agree refactoring is unnecessary.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/493e6cb4ba70
Make the use of setTimeout clearer and relocate it to head.js r=dimi

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/493e6cb4ba70