1777186 - [Wayland] Bookmark popup can be misplaced

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Bookmark popup can be misplaced after some open/close.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1777186 [Wayland] Use correct popup window to calculate parent fit r?emilio

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Screencast of the issue

Comment 3

[Martin Stránský [:stransky] (ni? me)]

We should uplift that to 103 at least.

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1760276

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/a6795c151e24

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something we want on ESR102?

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9283350 [details]
Bug 1777186 [Wayland] Use correct popup window to calculate parent fit r?emilio

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Wrong popup placement on Wayland.
• User impact if declined: Wrong popup placement on Wayland.
• Fix Landed on Version: 104
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We use a workaround to slow/flickering move-to-rect call. When popup window is placed inside toplevel one, it's safe to use plain move instead of move-to-rect.

But recently we use wrong popup to check the bounds so we may apply the workaround to wrong popup window. In this patch we fix that and use correct one.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9283350 [details]
Bug 1777186 [Wayland] Use correct popup window to calculate parent fit r?emilio

Makes life better for the distros with Wayland enabled by default. Approved for 102.2esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/92a4771d3b37

Comment 10

[Monica Chiorean]

Hello Martin,

I can not reproduce the issue using the information from video in order to confirm the fix, I tested on Ubuntu 20.4 using FF build 104.0a1(20220629070023) with Wayland settings. Are there any other step that I can use in order to reproduce it? Does the issue still reproduce for you on latest Beta 104.
0b9 (https://archive.mozilla.org/pub/firefox/candidates/104.0b9-candidates/), or on ESR 102.2(https://archive.mozilla.org/pub/firefox/candidates/102.2.0esr-candidates/build2/)? Thank you.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

(In reply to Monica Chiorean from comment #10)

Hello Martin,

I can not reproduce the issue using the information from video in order to confirm the fix, I tested on Ubuntu 20.4 using FF build 104.0a1(20220629070023) with Wayland settings. Are there any other step that I can use in order to reproduce it? Does the issue still reproduce for you on latest Beta 104.
0b9 (https://archive.mozilla.org/pub/firefox/candidates/104.0b9-candidates/), or on ESR 102.2(https://archive.mozilla.org/pub/firefox/candidates/102.2.0esr-candidates/build2/)? Thank you.

It may be specific to my popup setup. Let's keep it as is then.

Comment 12

[Monica Chiorean]

Removing qe-verify + based on Martin's comment.