1760276 - [Wayland] Don't use move-to-rect to place popups in area of main window

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

We use move-to-rect positioning which is kind of broken due to Gtk3 bug https://gitlab.gnome.org/GNOME/gtk/-/issues/1986 (which is fixed in Gtk4).

As a workaround we can:

• don't use move-to-rect of we know the popup is placed inside Firefox toplevel window
• don't use move-to-rect for popup resizes

Comment 1

[Martin Stránský [:stransky] (ni? me)]

This may fix Bug 1754950 for some cases.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1760276 [Wayland] When we check for popup resize workaround, consider toplevel window instead of parent one, r?emilio

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1760276 [Wayland] Avoid to use move-to-rect when possible r?emilio

Due to move-to-rect limitations (https://gitlab.gnome.org/GNOME/gtk/-/issues/1986) we try to avoid it when it's possible.

• Use plain popup resize/movement when popup is places inside of application toplevel window.
• Hide moved/scaled popup window only when move-to-rect is used.
• Clear mMoveToRectPopupRect before any move/resize and use Wayland compositor to place/size the window.

Depends on D141600

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1760276 [Wayland] Fix loop in popup move-to-rect resizes r?emilio

Use mMoveToRectPopupRect popup constrains in nsMenuPopupFrame::SetPopupPosition only and make it pernament.
In such setup works as screen size constraints.

Don't call SetPopupPosition from move-to-rect callback and let layout code to handle that.

Remove MoveToRectPopupRectClear() as it's not needed, we keep mMoveToRectPopupRect
in nsMenuPopupFrame as well as we keep screen sizes there.

Depends on D141601

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8e0571ab13b
[Wayland] When we check for popup resize workaround, consider toplevel window instead of parent one, r=emilio
https://hg.mozilla.org/integration/autoland/rev/3d351d90db7b
[Wayland] Avoid to use move-to-rect when possible r=emilio
https://hg.mozilla.org/integration/autoland/rev/e98dce4c58db
[Wayland] Fix loop in popup move-to-rect resizes r=emilio

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing multiple build bustages on nsMenuPopupFrame.cpp and nsWindow.cpp

Backout link

Push with failures

Failure log 1 // Failure log 2

Failure line: /builds/worker/checkouts/gecko/layout/xul/nsMenuPopupFrame.cpp:1574:9: error: expected expression

Failure line 2: /builds/worker/checkouts/gecko/widget/gtk/nsWindow.cpp:2041:14: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses]

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks.
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fcfa6cbdcc66e3ae296c888304d9265a2df41fe

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d62295e8fa9b
[Wayland] When we check for popup resize workaround, consider toplevel window instead of parent one, r=emilio
https://hg.mozilla.org/integration/autoland/rev/7757dfa7f893
[Wayland] Avoid to use move-to-rect when possible r=emilio
https://hg.mozilla.org/integration/autoland/rev/8a83aa3ec309
[Wayland] Fix loop in popup move-to-rect resizes r=emilio

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d62295e8fa9b
https://hg.mozilla.org/mozilla-central/rev/7757dfa7f893
https://hg.mozilla.org/mozilla-central/rev/8a83aa3ec309