1777222 - Optimize NewPlainObjectWithProperties

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1777222 part 1 - Inline AddPlainObjectProperties into NewPlainObjectWithProperties. r?jonco!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1777222 part 2 - Avoid calling NativeDefineDataProperty in the common case. r?jonco!

Depends on D150554

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1777222 part 3 - Remove NewObjectKind argument. r?jonco!

Depends on D150555

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1777222 part 4 - Use templates to optimize the unique-names case better. r?jonco!

If the caller knows there are no duplicate or integer keys, we don't need to check
for these cases.

Depends on D150556

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1777222 part 5 - Add a small cache to optimize NewPlainObjectWithProperties. r?jonco!

With TI we had a cache for this but we got rid of it when we removed TI. This patch
adds back a simpler version of it that caches the four most recently created
shapes. This cache has a good hit rate on the web and on Kraken's json-parse-financial
test.

Depends on D150557

Comment 6

[Jan de Mooij [:jandem]]

This speeds up JSON.parse quite a lot. Looking at the logs for the dromaeo jobs (this also runs Kraken) on autoland:

Linux64 before:

[#8] json-parse-financial  Cycles:10  Average:39.40  Median:40.00  stddev:1.65 (4.1%)  stddev-sans-first:1.64
Values: 41.0  39.0  42.0  38.0  40.0  38.0  37.0  40.0  41.0  38.0

Linux64 after:

[#8] json-parse-financial  Cycles:10  Average:27.20  Median:27.00  stddev:1.62 (6.0%)  stddev-sans-first:1.72
Values: 27.0  26.0  31.0  27.0  26.0  27.0  26.0  29.0  26.0  27.0

That's > 30% faster.

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4c8275c04902
https://hg.mozilla.org/mozilla-central/rev/a1a5403971ee
https://hg.mozilla.org/mozilla-central/rev/629757d308e1
https://hg.mozilla.org/mozilla-central/rev/a8698ac80892
https://hg.mozilla.org/mozilla-central/rev/585e41034e1e

Comment 8

[Mayank Bansal]

Big improvements here on AWFY:

json-parse-inspector-Average
json-parse-inspector-First
json-parse-inspector-Geometric
json-parse-inspector-Worst

---

Lots of smaller improvements here on AWFY:

Vanilla-ES2015-TodoMVC/CompletingAllItems
Vanilla-ES2015-TodoMVC/CompletingAllItems/Sync
Vanilla-ES2015-TodoMVC/DeletingItems
Vanilla-ES2015-TodoMVC/DeletingItems/Sync
VanillaJS-TodoMVC
VanillaJS-TodoMVC/CompletingAllItems
VanillaJS-TodoMVC/CompletingAllItems/Sync
VanillaJS-TodoMVC/DeletingAllItems
VanillaJS-TodoMVC/DeletingAllItems/Sync