1777351 - Forwarding message with non-ASCII content as attachment leads to mojibake (CJK)

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Rachel Martin]

Attachment: Test non-ASCII.eml

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Import the attached message (.eml file) into a folder by dragging it.

Display message, right click, forward as attachment. In the compose window that opens, double-click the attachment.

Actual results:

Mojibake.

Expected results:

Should be displayed properly.

Comment 1

[Rachel Martin]

Alice, can you please find the regression, it's very easy to reproduce. This works fine in TB 91.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a929acd962082697dd7a1e2103e04525a26a3a08&tochange=fbef0eae0aa6411a7f3916176f741e988ce60855
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2b624fdb002e6012209c725042f072a50bd4c4b6&tochange=6498a0eab61187297f034916680274b2df9e50e9

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: Bug 1777351 - Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

Comment 4

[Rachel Martin]

Many thanks, Alice, for finding this so quickly, and thanks to Ping for fixing it. It's quite a nasty bug, I assume forwarding messages as attachment in CJK languages is broken completely.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1247665c67a1
Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

Comment 6

[Ping Chen [:rnons] (away)]

Comment on attachment 9283578 [details]
Bug 1777351 - Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #): bug 1760025
User impact if declined: Forwarding message with non-ASCII content as attachment leads to mojibake
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9283578 [details]
Bug 1777351 - Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 103.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/78aa14301c11

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9283578 [details]
Bug 1777351 - Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #): 1760025
User impact if declined: Forwarding non-ascii mails as attachment is fubar'd
Testing completed (on c-c, etc.): on beta
Risk to taking this patch (and alternatives if risky):

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9283578 [details]
Bug 1777351 - Use IOUtils.write instead of writeUTF8 to fix attachment text encoding. r=john.bieling

[Triage Comment]
Approved for esr102

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 102.0.2:
https://hg.mozilla.org/releases/comm-esr102/rev/98809f4afc76