1777483 - Implement Extension button context menu (formerly "submenu")

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Tomislav Jovanovic :zombie]

Clicking the submenu button replaces the panel

• submenu has same items as right-click menu on the browser action
• except that [Pin to Overflow] is [Pin to toolbar]
• and items unrelated to extensions like [Menu bar] or [Customize]

Comment 1

[William Durand [:willdurand]]

Attachment: WIP: Bug 1777483 - Part 1 - Implement extension button submenu.

Comment 2

[William Durand [:willdurand]]

(In reply to Tomislav Jovanovic :zombie from comment #0)

Clicking the submenu button replaces the panel

• submenu has same items as right-click menu on the browser action
• except that [Pin to Overflow] is [Pin to toolbar]
• and items unrelated to extensions like [Menu bar] or [Customize]

We are going to implement this without a submenu/subview. Instead, we'll use a context menu that we can open using the "gear" icon.

Comment 3

[William Durand [:willdurand]]

While working on this bug, I noticed a problem with the context menu disappearing (in part) behind the panel. Looks like it's a known bug.

Comment 4

[William Durand [:willdurand]]

Attachment: Bug 1777483 - Part 1 - Add a new context menu for extensions in the unified extensions panel. r?mixedpuppy!

Comment 5

[William Durand [:willdurand]]

I am going to submit multiple patches to ease with the reviews. Here is how I plan to fix this bug (roughly):

1. add a new context menu for extensions in the unified extensions panel. It should be attached on the "cog"/"gear" button
2. add extension actions to the context menu introduced in (1)
3. add primary button support to open the context menu

The last piece would be:

except that [Pin to Overflow] is [Pin to toolbar]

which I am probably going to defer into a different bug as it kinda depends on Bug 1777489.

Comment 6

[William Durand [:willdurand]]

Attachment: Bug 1777483 - Part 2 - Add origin controls to the unified extensions context menu. r?rpl!

I only added two test cases to cover the integration between the new
context menu and the existing logic for the actions/origin controls
(both have their own tests).

Depends on D152665

Comment 7

[William Durand [:willdurand]]

Attachment: Bug 1777483 - Part 3 - Open context menu when clicking the menu button. r?mixedpuppy!

Depends on D152755

Comment 8

[William Durand [:willdurand]]

Attachment: Bug 1777483 - Part 4 - Add extension actions to the unified extensions context menu. r?rpl!

Depends on D152853

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/920759291618
Part 1 - Add a new context menu for extensions in the unified extensions panel.  r=mixedpuppy,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/9e6bb708b6c0
Part 2 - Add origin controls to the unified extensions context menu. r=rpl
https://hg.mozilla.org/integration/autoland/rev/baf27e2f44d6
Part 3 - Open context menu when clicking the menu button.  r=mixedpuppy

Comment 10

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/920759291618
https://hg.mozilla.org/mozilla-central/rev/9e6bb708b6c0
https://hg.mozilla.org/mozilla-central/rev/baf27e2f44d6

Comment 11

[William Durand [:willdurand]]

Oops, I forgot to add the leave-open keyword. I have one more patch to attach to this bug so I am going to change the status again. Sorry for the noise!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab1acf1b981
Part 4 - Add extension actions to the unified extensions context menu. r=rpl

Comment 13

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/2ab1acf1b981