1782203 - Add "Pin to toolbar" to unified extensions context menu

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[William Durand [:willdurand]]

In Bug 1777483, we introduced a context menu for the extensions in the unified extensions panel. We should add a "Pin to toolbar" item in this menu, which would pin the extension in the "unified-extensions" area introduced in Bug 1777489.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I think we'll similarly need a Pin to toolbar item in the toolbar-context-menu for items in the toolbar. I'll try to do both here.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r?willdurand!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1782203 - Unbreak existing context menu tests for Unified Extensions UI mode. r?willdurand!

Depends on D161200

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1782203 - Add tests for the new Pin to Toolbar context menu item. r?willdurand!

Depends on D161337

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b4cae098ea0
Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
https://hg.mozilla.org/integration/autoland/rev/0c90b1d40e9f
Unbreak existing context menu tests for Unified Extensions UI mode. r=willdurand,extension-reviewers
https://hg.mozilla.org/integration/autoland/rev/ae47d92443a7
Add tests for the new Pin to Toolbar context menu item. r=willdurand,extension-reviewers

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1777484 for causing failures on browser_unified_extensions_overflowable_toolbar.js

• backout: https://hg.mozilla.org/integration/autoland/rev/d947df2b1d28a06eaa909d0df4a936a633be577d
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=ae47d92443a76bc9f5ded0afec042b9026776b2a
• failure log: https://treeherder.mozilla.org/logviewer?job_id=396513655&repo=autoland&lineNumber=6727

[task 2022-11-14T23:54:25.514Z] 23:54:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_unified_extensions_overflowable_toolbar.js | Test timed out - 
[task 2022-11-14T23:54:25.516Z] 23:54:25     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-11-14T23:54:25.519Z] 23:54:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_unified_extensions_overflowable_toolbar.js | Extension left running at test shutdown - 
[task 2022-11-14T23:54:25.520Z] 23:54:25     INFO - Stack trace:
[task 2022-11-14T23:54:25.520Z] 23:54:25     INFO - chrome://mochikit/content/browser-test.js:test_ok:1457
[task 2022-11-14T23:54:25.521Z] 23:54:25     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:132
[task 2022-11-14T23:54:25.522Z] 23:54:25     INFO - chrome://mochikit/content/browser-test.js:nextTest:616
[task 2022-11-14T23:54:25.523Z] 23:54:25     INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1345
[task 2022-11-14T23:54:25.523Z] 23:54:25     INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1285
[task 2022-11-14T23:54:25.524Z] 23:54:25     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1034
[task 2022-11-14T23:54:25.524Z] 23:54:25     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1036
[task 2022-11-14T23:54:25.525Z] 23:54:25     INFO - Console message: [JavaScript Warning: "browser.ui.customized_widgets - The key length must be limited to 72 characters."]
[task 2022-11-14T23:54:25.526Z] 23:54:25     INFO - Console message: Warning: attempting to write 47375 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file.
[task 2022-11-14T23:54:25.528Z] 23:54:25     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-11-14T23:54:25.528Z] 23:54:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_unified_extensions_overflowable_toolbar.js | Extension left running at test shutdown - 

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e91d51f1ce90
Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
https://hg.mozilla.org/integration/autoland/rev/d17ea376ed45
Unbreak existing context menu tests for Unified Extensions UI mode. r=willdurand,extension-reviewers
https://hg.mozilla.org/integration/autoland/rev/50e57afebed3
Add tests for the new Pin to Toolbar context menu item. r=willdurand,extension-reviewers

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing lint failures on browser_unified_extensions_overflowable_toolbar.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/extensions/test/browser/browser_unified_extensions_overflowable_toolbar.js:116:7 | Duplicate key 'browser_specific_settings'. (no-dupe-keys)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10b3d3d98203
Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
https://hg.mozilla.org/integration/autoland/rev/745495ef73d3
Unbreak existing context menu tests for Unified Extensions UI mode. r=willdurand,extension-reviewers
https://hg.mozilla.org/integration/autoland/rev/7856b0c851cc
Add tests for the new Pin to Toolbar context menu item. r=willdurand,extension-reviewers

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/10b3d3d98203
https://hg.mozilla.org/mozilla-central/rev/745495ef73d3
https://hg.mozilla.org/mozilla-central/rev/7856b0c851cc

Comment 11

[Shravan Narayan]

Attachment: Bug 1782203 - Don't call hunspell rlbox::destroy_sandbox when create_sandbox failed r=bholley,glandium

Comment 12

[Shravan Narayan]

^ ignore the previous msg. I used the wrong bug id